Skip to content

fix: Parse Server option graphQLPublicIntrospection has no effect - #10696

Merged
mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/graphql-public-introspection-option-ignored
Sep 26, 2026
Merged

mtrezza merged 1 commit into
parse-community:alphafrom
mtrezza:fix/graphql-public-introspection-option-ignored

Conversation

@mtrezza

@mtrezza mtrezza commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Pull Request

Issue

Parse Server option graphQLPublicIntrospection has no effect. ParseGraphQLServer reads the option only from the config passed to its own constructor, and neither mount path puts it there: ParseServer.startApp (used by the CLI and the mountGraphQL option) constructs the GraphQL server without forwarding it, and when mounting via Express the option set on ParseServer is never consulted. Public introspection therefore stays disabled and schema suggestions stay stripped from GraphQL error messages for non-master callers, regardless of the configured value. The security check reads the Parse Server option, so it can report public introspection as enabled while it is actually disabled.

Approach

When building the Apollo server, use the value passed to ParseGraphQLServer if set, otherwise fall back to the Parse Server option graphQLPublicIntrospection. A value passed directly to ParseGraphQLServer keeps precedence, so Express setups that pass it there are unchanged.

Deployments that set graphQLPublicIntrospection: true on Parse Server will now get public introspection and unmasked GraphQL error messages, as configured. The default remains false.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Summary by CodeRabbit

  • Bug Fixes
    • Public introspection settings configured on Parse Server now apply to GraphQL requests when no GraphQL-server setting overrides them.
    • Introspection remains disabled by default on mounted GraphQL endpoints and can be enabled through the Parse Server option.

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 4c8b80a0-bf02-4917-8f81-5b90b879b811

📥 Commits

Reviewing files that changed from the base of the PR and between e6d8123 and c96eea5.

📒 Files selected for processing (2)
  • spec/ParseGraphQLServer.spec.js
  • src/GraphQL/ParseGraphQLServer.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

GraphQL public introspection now uses the GraphQL-server setting when non-nullish. Otherwise, it uses the Parse Server setting. Tests cover introspection access, validation suggestions, setting precedence, and mountGraphQL HTTP responses.

Changes

GraphQL Public Introspection

Layer / File(s) Summary
Resolve and apply the introspection setting
src/GraphQL/ParseGraphQLServer.js
The GraphQL-server setting takes precedence when non-nullish. Otherwise, the Parse Server setting is passed to both control plugins.
Verify setting precedence and HTTP behavior
spec/ParseGraphQLServer.spec.js
Tests cover enabled introspection, validation suggestions, explicit GraphQL-server disablement, and mountGraphQL responses with introspection disabled by default or enabled through the Parse Server option.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c96ee

No merge-blocking issue is identified; the change appears ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Check ✅ Passed No security vulnerability is introduced. The change only resolves the documented, server-side graphQLPublicIntrospection option and preserves an explicit GraphQL-server value, including false, thr…
Engage In Review Feedback ✅ Passed No review feedback comments were provided. The current review produced zero actionable findings, and no CodeRabbit review threads were returned. There was no feedback to ignore or resolve without enga…
Title check ✅ Passed The title begins with the required fix: prefix, uses a capitalized first letter after the prefix, and accurately describes the change.
Description check ✅ Passed The description includes the required Issue, Approach, and Tasks sections. It explains the problem, the implementation, the default behavior, and the completed testing and documentation tasks.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.84%. Comparing base (d77cd86) to head (c96eea5).
⚠️ Report is 1 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha   #10696   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         192      192           
  Lines       16936    16937    +1     
  Branches      257      257           
=======================================
+ Hits        15893    15894    +1     
  Misses       1021     1021           
  Partials       22       22           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza

mtrezza commented Sep 26, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@mtrezza
mtrezza merged commit 1ce39d4 into parse-community:alpha Sep 26, 2026
24 of 25 checks passed
@mtrezza
mtrezza deleted the fix/graphql-public-introspection-option-ignored branch September 26, 2026 09:47
parseplatformorg pushed a commit that referenced this pull request Sep 26, 2026
## [9.10.2-alpha.4](9.10.2-alpha.3...9.10.2-alpha.4) (2026-09-26)

### Bug Fixes

* Parse Server option `graphQLPublicIntrospection` has no effect ([#10696](#10696)) ([1ce39d4](1ce39d4))
@parseplatformorg

Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 9.10.2-alpha.4

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants