Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughGraphQL public introspection now uses the GraphQL-server setting when non-nullish. Otherwise, it uses the Parse Server setting. Tests cover introspection access, validation suggestions, setting precedence, and ChangesGraphQL Public Introspection
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to No merge-blocking issue is identified; the change appears ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #10696 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 192 192
Lines 16936 16937 +1
Branches 257 257
=======================================
+ Hits 15893 15894 +1
Misses 1021 1021
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
## [9.10.2-alpha.4](9.10.2-alpha.3...9.10.2-alpha.4) (2026-09-26) ### Bug Fixes * Parse Server option `graphQLPublicIntrospection` has no effect ([#10696](#10696)) ([1ce39d4](1ce39d4))
|
🎉 This change has been released in version 9.10.2-alpha.4 |
Pull Request
Issue
Parse Server option
graphQLPublicIntrospectionhas no effect.ParseGraphQLServerreads the option only from the config passed to its own constructor, and neither mount path puts it there:ParseServer.startApp(used by the CLI and themountGraphQLoption) constructs the GraphQL server without forwarding it, and when mounting via Express the option set onParseServeris never consulted. Public introspection therefore stays disabled and schema suggestions stay stripped from GraphQL error messages for non-master callers, regardless of the configured value. The security check reads the Parse Server option, so it can report public introspection as enabled while it is actually disabled.Approach
When building the Apollo server, use the value passed to
ParseGraphQLServerif set, otherwise fall back to the Parse Server optiongraphQLPublicIntrospection. A value passed directly toParseGraphQLServerkeeps precedence, so Express setups that pass it there are unchanged.Deployments that set
graphQLPublicIntrospection: trueon Parse Server will now get public introspection and unmasked GraphQL error messages, as configured. The default remainsfalse.Tasks
Summary by CodeRabbit