Conversation
pydantic-ai 0.0.37 imports opentelemetry._events, which was removed in opentelemetry-api>=1.30.0, breaking fresh installs. Pin opentelemetry-api to 1.29.0 and stop masking real module import failures as 'Patchflow X not found'.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1659
Fresh installs of patchwork are broken:
pydantic-ai0.0.37 importsopentelemetry._events, which was removed inopentelemetry-api>=1.30.0. The failure was also masked asPatchflow X not found in deque(['patchwork.patchflows']).Changes:
opentelemetry-apito1.29.0(last version shippingopentelemetry._events) and regeneratepoetry.lock.find_patchflowinpatchwork/app.pynow re-raises real import failures (dependencies missing/broken) instead of swallowing them, while still falling through gracefully for genuinely absent patchflows.Error loading patchflow X: <error>and exits 1 when a flow cannot be imported (mirrors existing error handling).Tests in
tests/common/test_app.pycover: missing flow returns None, broken dependency in a flow file, broken transitive dependency, and CLI surfacing of the error. Verified that withopentelemetry-api==1.44.0the CLI now prints the realModuleNotFoundErrorinstead of the misleading "not found" message.