chore(docs): Updated remaining TimesIcon to RhMicronsCloseIcon#12334
Open
tlabaj wants to merge 4 commits intopatternfly:mainfrom
Open
chore(docs): Updated remaining TimesIcon to RhMicronsCloseIcon#12334tlabaj wants to merge 4 commits intopatternfly:mainfrom
tlabaj wants to merge 4 commits intopatternfly:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplaced remaining imports/usages of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tlabaj
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react-icons/README.md`:
- Around line 8-10: The README snippet imports RhMicronsCloseIcon but still
renders <TimesIcon />; update the example so the rendered component matches the
import by replacing the JSX usage of TimesIcon with RhMicronsCloseIcon (i.e.,
set closeIcon to <RhMicronsCloseIcon />) or alternatively rename the import back
to TimesIcon so both the import and the rendering (TimesIcon,
RhMicronsCloseIcon, closeIcon) are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3d83d4d6-ddce-4c59-b706-a6a2c5d4017f
📒 Files selected for processing (7)
packages/code-connect/components/DualListSelector/DualListHeader.figma.tsxpackages/react-core/src/components/HelperText/examples/HelperText.mdpackages/react-core/src/components/HelperText/examples/HelperTextWithCustomIcon.tsxpackages/react-core/src/demos/CustomMenus/CustomMenus.mdpackages/react-core/src/demos/HelperText.mdpackages/react-core/src/demos/Toolbar.mdpackages/react-icons/README.md
Collaborator
|
Preview: https://pf-react-pr-12334.surge.sh A11y report: https://pf-react-pr-12334-a11y.surge.sh |
thatblindgeye
approved these changes
Apr 13, 2026
tlabaj
requested review from
a team,
dlabaj and
wise-king-sullyman
and removed request for
a team and
wise-king-sullyman
kmcfaul
requested changes
Apr 13, 2026
Contributor
kmcfaul
left a comment
kmcfaul
left a comment
There was a problem hiding this comment.
The import paths need to be updated as well (still pointing at the old icon) -
'@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
kmcfaul
reviewed
Apr 14, 2026
packages/react-icons/README.md
Outdated
|
|
||
| // Direct file path | ||
| import timesIcon from '@patternfly/react-icons/dist/static/times-icon.svg'; | ||
| import RhMicronsCloseIcon from '@patternfly/react-icons/dist/static/times-icon.svg'; |
Contributor
There was a problem hiding this comment.
One last update for the import path here!
kmcfaul
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12323
Update all instances of imported
TimesIconto importRhMicronsCloseIconinstead.Summary by CodeRabbit
Refactor
Documentation