Skip to content

Adding catalyst - #51

Draft
jmorice91 wants to merge 14 commits into
v4from
adding_catalyst
Draft

jmorice91 wants to merge 14 commits into
v4from
adding_catalyst

Conversation

@jmorice91

Copy link
Copy Markdown
Contributor

Reopen the previous #36 due to a force push

Comment thread debuntu/all/Dockerfile
Comment on lines +194 to +195
#RUN git -C /root clone --recurse-submodules https://github.com/pdidev/pdi.git /root/pdi
RUN git -C /root clone -b catalyst-plugin --recurse-submodules https://github.com/francois-kitware/pdi /root/pdi

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will have to be reverted before integration

jbigot
jbigot previously approved these changes Oct 30, 2026

@jbigot jbigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed a few changes, just for the fun of it. But this is ready to ship! Great work and good news.

Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/all/Dockerfile Resolved
Comment thread debuntu/all/Dockerfile Resolved
Comment thread spack/3-baselibs/deps.sh Resolved
Comment thread spack/4-mini/Dockerfile Resolved
Comment thread spack/4-mini/Dockerfile Resolved
@jbigot
jbigot deleted the branch pre_v5 November 16, 2026 16:00
@jbigot jbigot closed this Nov 16, 2026
@jmorice91 jmorice91 reopened this Nov 19, 2026
@jmorice91
jmorice91 changed the base branch from pre_v5 to v4 November 19, 2026 11:34
@jmorice91
jmorice91 dismissed jbigot’s stale review November 19, 2026 11:34

The base branch was changed.

Comment thread spack/3-baselibs/deps.sh
BASE_MPILIBS="py-mpi4py veloc"
BASE_MPILIBS="py-mpi4py veloc conduit~hdf5~hdf5_compat~fortran libcatalyst+mpi+python"
#TODO: libcatalyst+python was introduced in spack 0.22, switch back to a single list when our minimum requirement goes at or above that
BASE_MPILIBS_OLDSPACK="py-mpi4py veloc libcatalyst+mpi"

@jmorice91 jmorice91 Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remark on spack receipt:

  1. version 0.22:

variant conduit not defined ("+conduit") implies internal catalyst conduit is used

  1. develop:

spack package libcatalyst use external conduit by default

self.define("CATALYST_WITH_EXTERNAL_CONDUIT", True),

and conduit require by default two variants hdf5 and hdf5_compt.
hdf5_compt implies to add a version of hdf5 that is not supported by PDI.
--> I remove hdf5* because, of what I understand, we don't want hdf5 in mini and catalyst don't need hdf5 in v2.*
--> As we don't required variant fortran for catalyst, the variant fortran is removed for conduit

To use the internal catalyst conduit, we need to change the receipt libcatalyst package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants