Repository navigation
Conversation
| #RUN git -C /root clone --recurse-submodules https://github.com/pdidev/pdi.git /root/pdi | ||
| RUN git -C /root clone -b catalyst-plugin --recurse-submodules https://github.com/francois-kitware/pdi /root/pdi |
There was a problem hiding this comment.
this will have to be reverted before integration
jbigot
left a comment
There was a problem hiding this comment.
I proposed a few changes, just for the fun of it. But this is ready to ship! Great work and good news.
| BASE_MPILIBS="py-mpi4py veloc" | ||
| BASE_MPILIBS="py-mpi4py veloc conduit~hdf5~hdf5_compat~fortran libcatalyst+mpi+python" | ||
| #TODO: libcatalyst+python was introduced in spack 0.22, switch back to a single list when our minimum requirement goes at or above that | ||
| BASE_MPILIBS_OLDSPACK="py-mpi4py veloc libcatalyst+mpi" |
There was a problem hiding this comment.
remark on spack receipt:
- version 0.22:
variant conduit not defined ("+conduit") implies internal catalyst conduit is used
- develop:
spack package libcatalyst use external conduit by default
self.define("CATALYST_WITH_EXTERNAL_CONDUIT", True),
and conduit require by default two variants hdf5 and hdf5_compt.
hdf5_compt implies to add a version of hdf5 that is not supported by PDI.
--> I remove hdf5* because, of what I understand, we don't want hdf5 in mini and catalyst don't need hdf5 in v2.*
--> As we don't required variant fortran for catalyst, the variant fortran is removed for conduit
To use the internal catalyst conduit, we need to change the receipt libcatalyst package.
Reopen the previous #36 due to a force push