Skip to content

General code cleanup #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonrebm wants to merge 9 commits into
base: main
Choose a base branch
from
Open

General code cleanup #55

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c6a86f8
Do not use named variadic macros
jonrebm Dec 12, 2025
6112a0b
Do not use c23 empty initializers
jonrebm Dec 12, 2025
e998b60
Don't do arithmetic on void pointers
jonrebm Dec 12, 2025
3e6ec3e
microcom.h: switch to simple min/max macros
jonrebm Dec 12, 2025
dc07164
commands_fsl_imx.c: handle read() return value
jonrebm Dec 13, 2025
53504fe
commands_fsl_imx.c: drop unused variable i
jonrebm Dec 13, 2025
452d793
treewide: Use SPDX license headers
jonrebm Dec 13, 2025
698d29d
treewide: Format using uncrustify and add uncrustify.cfg
jonrebm Dec 12, 2025
331c38c
microcom.c: Do not use uninitialized memory
jonrebm Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion microcom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ int main(int argc, char *argv[])
{ "listenonly", no_argument, NULL, 'o'},
{ "answerback", required_argument, NULL, 'a'},
{ "version", no_argument, NULL, 'v' },
{ },
{ 0, 0, 0, 0 },
Copy link
Contributor

@ukleinek ukleinek Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I'd say either use { 0 } here if you don't like the c23 stuff, or use NULL instead of 0 to initialize pointers.

};

while ((opt = getopt_long(argc, argv, "hp:s:t:c:dfl:oi:a:e:v", long_options, NULL)) != -1) {
Expand Down