telnet.c: rewrite command handling #57
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was unable to handle any command sequences split across the (maximum) 1024 bytes buffers, leading to crashes, out-of-bounds access and data corruption. The previous implementation went into great detail handling plenty of command strings but only provided stubs debug-printing those commands. To keep the code concise, the new version prints a hexdump of all command sequences it extracts from the bytestream (regardless of whether they're handled or not). Signed-off-by: Jonas Rebmann <[email protected]>
This was referenced Dec 14, 2025
Draft
a3f
reviewed
Dec 15, 2025
| char connected_host[256], connected_port[30]; | ||
|
|
||
| ios = malloc(sizeof(*ios)); | ||
| ios = calloc(1, sizeof(struct telnet_ios)); |
Member
There was a problem hiding this comment.
I would prefer you allocate telnet_ios here, then add a ios = &telnet_ios->base after the NULL check. Otherwise, anyone looking for future issues will stumble upon this and will have to verify themselves that this is kosher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was unable to handle any command sequences split across the (maximum) 1024 bytes buffers, leading to crashes, out-of-bounds access and data corruption.
The previous implementation went into great detail handling plenty of command strings but only provided stubs debug-printing those commands.
To keep the code concise, the debug-prints in the new version are just a hexdump of all command sequences it extracts from the bytestream (regardless of whether they're handled or not). There are no more stubs for individual unsupported command sequences.