[ENHANCEMENT] theme: add support for color-scheme#78
Merged
Gladorme merged 2 commits intoperses:mainfrom Mar 11, 2026
Merged
Conversation
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
6 tasks
jgbernalp
approved these changes
Mar 9, 2026
jgbernalp
reviewed
Mar 9, 2026
components/src/theme/theme.ts
Outdated
| return { | ||
| MuiCssBaseline: { | ||
| styleOverrides: { | ||
| body: { |
Contributor
There was a problem hiding this comment.
On second thought, we probably want to allow to disable this via props on the getTheme. For embedded use cases that do not define their own overrides, then it will affect the host applications.
Member
Author
There was a problem hiding this comment.
Ok, fair. I will update it
jgbernalp
requested changes
Mar 9, 2026
Signed-off-by: Guillaume LADORME <Gladorme@users.noreply.github.com>
Member
Author
|
@jgbernalp should be fine now 😄 |
jgbernalp
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support of color scheme in
getTheme, in order to have color scheme applied to all body.If not applied to body, components spawning outside will not have color scheme applied (Ie: drawer, modal, ...)
Related to: perses/perses#3926
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: