Test that Expected is mandatory via metadata, not by invoking without it - #2965
Open
nohwnd wants to merge 1 commit into
Open
Test that Expected is mandatory via metadata, not by invoking without it#2965nohwnd wants to merge 1 commit into
nohwnd wants to merge 1 commit into
Conversation
The "Requires Expected" tests invoked the assertion with the mandatory Expected missing and expected a ParameterBindingException. A missing mandatory parameter makes PowerShell prompt for the value, which throws only in a non-interactive host. In an interactive test.ps1 run, or the release build (before pester#2963), it prompts and hangs forever instead. Check the parameter metadata says Mandatory instead, so the test never prompts regardless of host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2963. The "Requires Expected" tests on Should-NotBeString, Should-BeFasterThan and Should-BeSlowerThan (#2938) invoked the assertion with the mandatory Expected missing and expected a ParameterBindingException. That only throws in a non-interactive host. Interactively (a local
test.ps1run, or the release build before #2963) a missing mandatory parameter prompts for the value and hangs forever.Check the parameter metadata reports Mandatory instead, so the test never prompts regardless of host. #2963 keeps the release non-interactive as defense in depth.
🤖