Add Mohit Rawat to contributors #501
Conversation
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…elop/actions/checkout-6 Bump actions/checkout from 5 to 6
pumpup to 4.1.0 dev
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
…g-develop Translations update from OSGeo Weblate
Currently translated at 100.0% (5383 of 5383 strings) Co-authored-by: Daniel Nylander <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/sv/ Translation: pgRouting/pgRouting
Currently translated at 86.2% (4644 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4643 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4641 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4640 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4637 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4636 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4635 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4634 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4633 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4632 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4631 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4630 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4629 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4628 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4627 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4626 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4625 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4624 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4623 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4622 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4621 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4620 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4619 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4618 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4617 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4616 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4615 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4614 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4613 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4612 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4611 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4610 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4609 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4608 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4607 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4605 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4604 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4603 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4602 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4601 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4600 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4599 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4598 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4597 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4596 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4595 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4594 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4593 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4590 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4589 of 5383 strings) Co-authored-by: DeepL <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Currently translated at 86.3% (4646 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.2% (4643 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4640 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.1% (4635 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4634 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4633 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 86.0% (4632 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4627 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.9% (4626 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.8% (4622 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4617 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.7% (4616 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4613 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.6% (4610 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4607 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4605 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.5% (4603 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4601 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4600 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.4% (4598 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4597 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4595 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4594 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.3% (4593 of 5383 strings) Translated using Weblate (Spanish) Currently translated at 85.2% (4590 of 5383 strings) Co-authored-by: Celia Virginia Vergara Castillo <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Currently translated at 86.3% (4646 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.3% (4650 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.3% (4650 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4651 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4652 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4653 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4653 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4654 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4654 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4655 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4655 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4656 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.4% (4656 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.5% (4658 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.5% (4658 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4663 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4663 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4664 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4664 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4665 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4666 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4666 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.6% (4667 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.7% (4672 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.7% (4672 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4673 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4674 of 5383 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 86.8% (4675 of 5383 strings) Co-authored-by: Celia Virginia Vergara Castillo <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/ Translation: pgRouting/pgRouting
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Co-authored-by: Weblate <[email protected]> Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/ Translation: pgRouting/pgRouting
Currently translated at 87.3% (4700 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.3% (4700 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.3% (4701 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.5% (4714 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
Currently translated at 87.5% (4714 of 5382 strings) Translation: pgRouting/pgRouting Translate-URL: https://weblate.osgeo.org/projects/pgrouting/pgrouting-develop/es/
WalkthroughpgRouting version bump from 4.0.0 to 4.1.0 across the codebase. Updates include GitHub Actions workflows to use checkout@v6, version references in CMakeLists.txt, function signatures, SQL files, locale metadata, documentation headers, and development tools. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This pull request appears to be primarily a version bump from pgRouting 4.0.0 to 4.1.0-dev, with the addition of contributor "Mohit Rawat" to the contributors list. The PR title "Add Mohit Rawat to contributors" understates the scope of changes, as this is effectively a full version bump preparation that includes updating build configurations, documentation, localization files, GitHub Actions workflows, and test scripts.
Key changes:
- Version bumped from 4.0.0 to 4.1.0-dev across the project
- Added "Mohit Rawat" to the contributors list in alphabetical order
- Updated all GitHub Actions workflows to use actions/checkout@v6 (critical issue - v6 does not exist)
- Updated locale files and documentation for version 4.1
- Added release notes section for pgRouting 4.1.0
Reviewed changes
Copilot reviewed 36 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Updated project version to 4.1.0 with -dev suffix, added 4.1 to MINORS list and 4.0.0 to OLD_SIGNATURES |
| NEWS.md | Added pgRouting 4.1.0 release notes section |
| doc/src/release_notes.rst | Added pgRouting 4.1 section with 4.1.0 release notes |
| doc/src/pgRouting-introduction.rst | Added "Mohit Rawat" to individual contributors list in alphabetical order |
| doc/src/pgRouting-concepts.rst | Fixed "See also" to "See Also" for section header |
| doc/_static/page_history.js | Added '4.1' to versionsArr array |
| docqueries/version/*.result | Updated version strings from 4.0.0 to 4.1.0-dev |
| locale//LC_MESSAGES/.po | Updated version references from v3.8/v4.0 to v4.1 and copyright year |
| locale/pot/*.pot | Updated version and copyright information to v4.1, updated POT-Creation-Date |
| sql/coloring/sequentialVertexColoring.sql | Fixed comment format from ---3.2 to --v3.2 |
| sql/sigs/pgrouting--4.1.sig | New signature file for pgRouting 4.1 with 330 function signatures |
| sql/scripts/build-extension-update-files.pl | Added version_4_1 regex pattern and set as current version |
| tools/testers/pg_prove_tests.sh | Updated version from 4.0.0 to 4.1.0 |
| tools/developer/run.sh | Uncommented QUERIES_DIRS and TAP_DIRS (re-enabled test processing) |
| tools/developer/pumpup_version.sh | Fixed file path from doc-full_version.result to full_version.result |
| .github/workflows/*.yml | Updated actions/checkout from v5 to v6 (all 12+ workflow files) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #QUERIES_DIRS="" | ||
| #TAP_DIRS="" |
There was a problem hiding this comment.
These lines have been uncommented, which re-enables processing of queries and tap tests. The comment above these lines says "To skip processing queries and tap tests", so uncommenting them means the script will now process these tests. This change should be intentional - if you meant to skip processing queries and tap tests during development, these lines should remain commented out. If you want to enable test processing, then this change is correct.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
♻️ Duplicate comments (6)
.github/workflows/clang.yml (1)
58-58: Checkout action upgrade is consistent with other workflows..github/workflows/boost_version.yml (1)
74-74: Checkout action upgrade is consistent with other workflows..github/workflows/macos.yml (1)
51-51: Checkout action upgrade is consistent with other workflows..github/workflows/centos.yml (1)
35-35: Checkout action upgrade is consistent with other workflows..github/workflows/website.yml (1)
31-31: Checkout action upgrade is consistent with other workflows..github/workflows/release.yml (1)
21-21: Checkout action upgrade is consistent with other workflows.
🧹 Nitpick comments (6)
sql/coloring/sequentialVertexColoring.sql (1)
30-30: Prefer-- v3.2(with a space) for comment-style consistency.
Current--v3.2works, but the space tends to match common SQL comment conventions.---v3.2 +-- v3.2tools/developer/run.sh (1)
62-63: Behavioral change: Removes ability to skip query and tap test processing.By commenting out the empty assignments that were previously used to skip processing (lines 62-63), this change forces the script to always process the "dijkstra" subdirectories (lines 58-59). This removes a developer convenience feature.
Additionally, this change is unrelated to the PR's stated objective of adding a contributor name.
Consider keeping the skip option available for developers who need faster iteration during local development. Alternatively, document this change if the always-on behavior is intentional for the 4.1 development cycle.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (1)
68-70: Consider leavinglocale/enmsgstr empty (or ensure your gettext workflow expects identity translations). Many entries flip from empty tomsgstridentical tomsgidfor code literals / inline markup. That’s not wrong, but it increases churn/merge conflicts and may be redundant for English catalogs depending on how docs are built. If your pipeline requires non-emptymsgstr, OK—otherwise consider keeping these empty and lettingmsgidact as the English string.Also applies to: 77-79, 124-126, 145-147, 154-156, 160-162, 166-168, 175-177, 204-206, 210-212, 219-221, 225-227, 231-233, 240-242, 246-248, 279-284, 458-472, 595-600, 787-804, 852-854, 861-864, 867-870, 882-884, 905-907, 913-915, 926-928, 932-934, 938-940, 944-946, 959-961, 965-967, 971-973, 1018-1020, 1037-1039, 1043-1045, 1076-1078, 1088-1090, 1100-1102, 1116-1118, 1135-1137, 1156-1158, 1166-1168, 1175-1177, 1187-1189, 1199-1201, 1209-1210, 1220-1222, 12929-12931, 12955-12957, 13334-13336, 1661-1663, 1685-1687, 1691-1693, 1814-1822
CMakeLists.txt (1)
33-35: HardcodingPROJECT_VERSION_DEVto-devrisks shipping dev-suffixed artifacts.
If releases are expected to be4.1.0(no suffix), consider makingPROJECT_VERSION_DEVconfigurable via a cache var/option (default-devfor main, empty for release), or set it based on an explicit release toggle.
-->project(PGROUTING VERSION 4.1.0 LANGUAGES C CXX ) -set(PROJECT_VERSION_DEV "-dev") +set(PROJECT_VERSION_DEV "-dev" CACHE STRING "Version suffix (e.g., -dev for development builds, empty for releases)") string(TOLOWER "${PROJECT_NAME}" PROJECT_NAME_LOWER) ... add_definitions(-DPROJECT_VERSION="${PROJECT_VERSION}${PROJECT_VERSION_DEV}") set(PROJECT_LIB_NAME "${PROJECT_NAME_LOWER}-${PROJECT_LIB_VERSION}")Also applies to: 41-42
locale/pot/pgrouting_doc_strings.pot (2)
6913-6916: Consider avoiding a hardcoded version in the “upgrade” sentence (if docs support|release|).
"To upgrade pgRouting in the database to version 4.1.0 ..."may become stale across releases. If the docs already use substitutions (e.g.,|release|), consider using that in the source RST/MD and regenerating the POT.
13495-13505: New 4.1/4.1.0 release-notes msgids: check for duplication and consistent naming.
The newpgRouting 4.1/pgRouting 4.1.0 Release Notes/ milestone link / placeholder (No changes yet) entries look fine for scaffolding; just ensure the same strings aren’t introduced elsewhere with minor wording differences (which would fragment translations).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (36)
.github/workflows/boost_version.yml(2 hunks).github/workflows/centos.yml(1 hunks).github/workflows/check-files.yml(5 hunks).github/workflows/check-queries.yml(1 hunks).github/workflows/clang.yml(1 hunks).github/workflows/doc-check.yml(1 hunks).github/workflows/macos.yml(1 hunks).github/workflows/release.yml(1 hunks).github/workflows/ubuntu.yml(1 hunks).github/workflows/update-locale.yml(1 hunks).github/workflows/update.yml(3 hunks).github/workflows/website.yml(1 hunks)CMakeLists.txt(2 hunks)NEWS.md(1 hunks)doc/_static/page_history.js(1 hunks)doc/src/pgRouting-concepts.rst(1 hunks)doc/src/pgRouting-introduction.rst(1 hunks)doc/src/release_notes.rst(1 hunks)docqueries/version/full_version.result(1 hunks)docqueries/version/version.result(1 hunks)locale/de/LC_MESSAGES/index.po(1 hunks)locale/en/LC_MESSAGES/index.po(1 hunks)locale/en/LC_MESSAGES/pgrouting_doc_strings.po(181 hunks)locale/es/LC_MESSAGES/index.po(1 hunks)locale/ja/LC_MESSAGES/index.po(1 hunks)locale/ko/LC_MESSAGES/index.po(1 hunks)locale/pot/index.pot(1 hunks)locale/pot/pgrouting_doc_strings.pot(5 hunks)locale/sv/LC_MESSAGES/index.po(1 hunks)locale/zh_Hans/LC_MESSAGES/index.po(1 hunks)sql/coloring/sequentialVertexColoring.sql(1 hunks)sql/scripts/build-extension-update-files.pl(2 hunks)sql/sigs/pgrouting--4.1.sig(1 hunks)tools/developer/pumpup_version.sh(1 hunks)tools/developer/run.sh(1 hunks)tools/testers/pg_prove_tests.sh(1 hunks)
🔇 Additional comments (31)
doc/src/pgRouting-concepts.rst (1)
1863-1864: Clarify the alignment between PR objective and this file change.The PR objective states "Add Mohit Rawat to contributors," but this file only shows a capitalization change from "See also" to "See Also" on line 1863. There's no visible addition of a contributor name in the provided code segment.
Is this the correct file for the contributor addition, or should the contributors list modification be in a separate file (e.g., AUTHORS, CONTRIBUTORS, or a dedicated contributors section)?
locale/de/LC_MESSAGES/index.po (1)
2-8: Version metadata updates look consistent, but PR objectives mismatch.The version bump from v3.8 to v4.1 in the copyright line and
Project-Id-Versionfield is consistent with similar changes across other locale files. However, this change does not align with the stated PR objective of "Add Mohit Rawat to contributors list."Please verify that these changes belong to this PR or if the contributor list changes are in separate files not included in this review.
locale/pot/index.pot (1)
2-9: LGTM!Version metadata updated consistently from v3.8 to v4.1 in both the copyright comment and
Project-Id-Versionfield. This aligns with the version bump across other locale files.docqueries/version/version.result (1)
9-9: LGTM!The expected result for
pgr_version()correctly reflects the development version4.1.0-dev, consistent with the project-wide version bump to 4.1.0.locale/zh_Hans/LC_MESSAGES/index.po (1)
2-8: LGTM!Version metadata updated consistently to v4.1 in the copyright comment and
Project-Id-Versionfield, matching other locale files in this PR.locale/sv/LC_MESSAGES/index.po (1)
2-8: LGTM!Version metadata updated consistently to v4.1, aligning with the other locale files in this version bump.
doc/src/pgRouting-introduction.rst (1)
156-159: Contributor addition is consistent with the alphabetical list formatting.
Placement and punctuation match the surrounding entries.locale/ja/LC_MESSAGES/index.po (1)
2-8: PO header version bump looks correct.
No translation payload changes; just metadata.locale/es/LC_MESSAGES/index.po (1)
2-8: PO header version bump looks correct.doc/src/release_notes.rst (1)
30-55: Please verify rendered ToC structure after inserting the 4.1 / 4.0 sections.
With the newly added 4.0.. contents:: Contents(Line 51-54) plus the existing contents block later under 4.0.0-alpha1, Sphinx may render redundant ToC entries depending on configuration.locale/ko/LC_MESSAGES/index.po (1)
2-8: PO header version bump looks correct.locale/en/LC_MESSAGES/index.po (1)
2-9: PO header version bump looks correct (metadata-only).sql/scripts/build-extension-update-files.pl (1)
71-81: Major inconsistency: PR objectives don't match the code changes.The PR title states "Add Mohit Rawat to contributors" and the description mentions "Task 2: Added my name to contributors list", but this file (and all others in the PR) contains version bump changes from 4.0 to 4.1, with no contributor list modifications visible.
The version bump changes themselves appear technically correct: the regex pattern for 4.1 follows the established convention, and updating
$currentto$version_4_1is the expected change for targeting 4.1 as the new baseline.Please clarify:
- Is this the correct PR, or were the wrong files attached?
- Should this PR be retitled to reflect the version bump changes?
- Where are the contributor list changes mentioned in the PR description?
docqueries/version/full_version.result (1)
8-10: Version output updated correctly for 4.1.0-dev.The expected test output has been properly updated to reflect version 4.1.0-dev, and the header separator width has been adjusted to match the new string length. The changes are technically correct.
However, this file (like all others in the PR) contains version bump changes rather than contributor list modifications as stated in the PR objectives.
tools/developer/pumpup_version.sh (1)
127-127: Good catch: Fixes incorrect file path.The file path has been corrected from
docqueries/version/doc-full_version.resulttodocqueries/version/full_version.result, removing an erroneous "doc-" prefix. This ensures the version pump script updates the correct file when performing minor version bumps.Like all other changes in this PR, this is unrelated to the stated objective of adding a contributor name.
doc/_static/page_history.js (1)
8-8: Documentation version support correctly updated for 4.1.The
versionsArrhas been properly updated to include '4.1' as the newest version, maintaining the correct descending order. This will enable the documentation site to render version navigation links for the 4.1 release alongside 4.0.However, this change (like all others in this PR) relates to the version bump rather than adding a contributor as stated in the PR title and description.
locale/en/LC_MESSAGES/pgrouting_doc_strings.po (2)
8396-8401: Contributor list update looks correct; keep alphabetical ordering consistent. “Mohit Rawat” appears in the “Individuals (in alphabetical order)” list; please double-check ordering around neighboring names (e.g., “Mohamed …, Mohit Rawat, Mukul …”).
3916-3918: Empty msgstr in English locale PO file is correct behavior. In gettext PO files, the English source language typically has emptymsgstrvalues—this is intentional and standard. Whenmsgstris empty, gettext automatically falls back to themsgidtext, which is the expected behavior for the source language. Your release notes sections ("pgRouting 4.0" and "pgRouting 4.1.0 Release Notes") will display correctly without requiring populatedmsgstrentries in the English locale.CMakeLists.txt (1)
49-62: MINORS / OLD_SIGNATURES update looks consistent for introducing 4.1.
Putting4.1first inMINORSand adding4.0.0toOLD_SIGNATURESaligns with rolling forward the version history and upgrade signatures.locale/pot/pgrouting_doc_strings.pot (3)
2-11: POT header bump looks consistent—make sure it’s generator-driven.
TheProject-Id-Version: pgRouting v4.1and updatedPOT-Creation-Dateare fine, but if this file is usually auto-generated, it’d be good to ensure these edits come from the normal i18n/doc build pipeline to avoid manual drift.
3523-3525: Confirm whethermsgid "pgRouting 4.0"is intentionally unchanged.
This line is marked modified, but still readspgRouting 4.0. If this section is meant to be the 4.0 release-notes header, fine; if the intent was to bump it to 4.1, it should be updated in the source docs so the POT regenerates accordingly.
7204-7206: Contributor addition looks good (and placement is alphabetically consistent).
“Mohit Rawat” appears correctly inserted in the “Individuals (in alphabetical order)” list..github/workflows/doc-check.yml (1)
56-56: actions/checkout@v6 is a stable, current version with appropriate migration path from v5.The upgrade is safe for this workflow. Note that v6 has minor changes in credentials handling (written to separate file under $RUNNER_TEMP instead of .git/config) and requires GitHub Actions Runner v2.329.0+ for Docker container authentication, but these do not impact standard workflows.
tools/testers/pg_prove_tests.sh (1)
40-40: Version parameter updated for pgRouting 4.1.0 test baseline.The test setup now correctly targets the 4.1.0 version, aligning with the project version bump across CI workflows and documentation.
.github/workflows/ubuntu.yml (1)
43-43: GitHub Actions checkout upgraded to v6.GitHub provides security updates and fixes major breaking changes for v6. The upgrade maintains compatibility with existing workflows.
.github/workflows/check-queries.yml (1)
58-58: GitHub Actions checkout upgraded to v6.Maintains consistency with the broader workflow modernization across the codebase.
.github/workflows/update-locale.yml (1)
33-33: GitHub Actions checkout upgraded to v6.Part of the consistent workflow migration to v6 across the repository.
.github/workflows/update.yml (3)
51-51: Matrix updated to include 4.0.0 for upgrade testing.Adding 4.0.0 to the
old_pgrmatrix enables testing the upgrade path from pgRouting 4.0.0 to the new 4.1.0 version, ensuring smooth migration for existing installations.
54-54: GitHub Actions checkout upgraded to v6.Both checkout steps (lines 54 and 98) are updated consistently with the broader workflow migration.
Also applies to: 98-98
148-148: Extension upgrade target updated to 4.1.0.The
ALTER EXTENSION pgrouting UPDATEcommand now targets the new 4.1.0 version, properly testing the upgrade path in the CI matrix..github/workflows/check-files.yml (1)
23-23: GitHub Actions checkout upgraded to v6 across all jobs.All six checkout steps (in jobs: Signature_check, News_check, License_check, Shell_check, and style-check) are consistently updated to v6, modernizing the file checks workflow.
Also applies to: 32-32, 43-43, 54-54, 65-65, 67-67
| psql -c "CREATE DATABASE ___pgr___test___;" | ||
| DIR=$(git rev-parse --show-toplevel) | ||
| bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "4.0.0" | ||
| bash "${DIR}/tools/testers/setup_db.sh" "${PGPORT}" ___pgr___test___ "${PG_RUNNER_USER}" "4.1.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search for remaining references to version 4.0.0 that might need updating
echo "=== Searching for version 4.0.0 references ==="
rg -n "4\.0\.0" -C2 2>/dev/null || echo "No 4.0.0 references found"
echo -e "\n=== Searching for version 4.1.0 references to confirm updates ==="
rg -n "4\.1\.0" -C2 2>/dev/null || echo "No 4.1.0 references found"
echo -e "\n=== Checking CMakeLists.txt for version declaration ==="
rg -n "project\(PGROUTING VERSION" CMakeLists.txt 2>/dev/null || echo "Pattern not found"
echo -e "\n=== Checking boost_version.yml for context ==="
cat -n .github/workflows/boost_version.yml | head -140 | tail -20Repository: pgRouting/GSoC-pgRouting
Length of output: 50381
🏁 Script executed:
#!/bin/bash
# Check the project version declaration in CMakeLists.txt
echo "=== Project version in CMakeLists.txt ==="
head -100 CMakeLists.txt | grep -n "project\|VERSION"
echo -e "\n=== Full context around project declaration ==="
head -20 CMakeLists.txt
# Check setup_db.sh to see if it uses version parameter
echo -e "\n=== Checking setup_db.sh for version usage ==="
cat -n tools/testers/setup_db.sh | head -50
# Check if there are other calls to setup_db.sh with version parameters
echo -e "\n=== Searching for other calls to setup_db.sh ==="
rg "setup_db\.sh.*4\." -B2 -A2 2>/dev/null | head -100Repository: pgRouting/GSoC-pgRouting
Length of output: 4674
🏁 Script executed:
#!/bin/bash
# Search for other workflow files that might reference version
echo "=== Other workflow files ==="
find .github/workflows -name "*.yml" -o -name "*.yaml" | head -20
echo -e "\n=== Searching for version in all workflow files ==="
grep -r "pgrouting WITH VERSION\|setup_db.sh.*4\." .github/workflows/ 2>/dev/null || echo "No matches found"
echo -e "\n=== Checking if there are other shell scripts that call setup_db.sh ==="
rg "setup_db\.sh" --type=sh -l 2>/dev/null
echo -e "\n=== Full content of pg_prove_tests.sh relevant section ==="
grep -n "setup_db.sh\|4\.1\.0\|4\.0\.0" tools/testers/pg_prove_tests.shRepository: pgRouting/GSoC-pgRouting
Length of output: 984
🏁 Script executed:
#!/bin/bash
echo "=== tools/developer/taptest.sh ==="
grep -n "setup_db.sh\|4\.1\.0\|4\.0\.0" tools/developer/taptest.sh || echo "No version references found"
echo -e "\n=== ci/winnie/build_pgrouting.sh ==="
grep -n "setup_db.sh\|4\.1\.0\|4\.0\.0" ci/winnie/build_pgrouting.sh || echo "No version references found"
echo -e "\n=== Context around setup_db.sh calls in taptest.sh ==="
grep -B5 -A5 "setup_db.sh" tools/developer/taptest.sh || echo "Not found"
echo -e "\n=== Context around setup_db.sh calls in build_pgrouting.sh ==="
grep -B5 -A5 "setup_db.sh" ci/winnie/build_pgrouting.sh || echo "Not found"Repository: pgRouting/GSoC-pgRouting
Length of output: 1088
🏁 Script executed:
#!/bin/bash
echo "=== Full context around PGRVERSION in taptest.sh ==="
sed -n '50,90p' tools/developer/taptest.sh
echo -e "\n=== Searching for how PGRVERSION is used in taptest.sh ==="
grep -n "PGRVERSION\|PGR_VERSION" tools/developer/taptest.sh
echo -e "\n=== Full context around PGR_VERSION in build_pgrouting.sh ==="
grep -n "PGR_VERSION" ci/winnie/build_pgrouting.sh
echo -e "\n=== Checking beginning of build_pgrouting.sh for version setup ==="
head -50 ci/winnie/build_pgrouting.sh | grep -n "VERSION\|version"Repository: pgRouting/GSoC-pgRouting
Length of output: 1890
Update hardcoded version in tools/developer/taptest.sh
Line 60 of tools/developer/taptest.sh contains a hardcoded version PGRVERSION="4.0.0" that should be updated to PGRVERSION="4.1.0" to match the project version and remain consistent with the test database setup.
Note: The version update in .github/workflows/boost_version.yml is correct. Other references to 4.0.0 in the codebase are legitimate (release notes, deprecation messages, backward compatibility tests, and OLD_SIGNATURES list in CMakeLists.txt).
🤖 Prompt for AI Agents
In tools/developer/taptest.sh around line 60, the PGRVERSION variable is
hardcoded as PGRVERSION="4.0.0" which is out of sync with the project; update
that line to PGRVERSION="4.1.0" so the script matches the test DB and workflow.
Make the single-line change only, keep quoting and formatting identical, and run
a quick grep for other occurrences to confirm no unintended edits.
| project(PGROUTING VERSION 4.1.0 | ||
| LANGUAGES C CXX ) | ||
| set(PROJECT_VERSION_DEV "") | ||
| set(PROJECT_VERSION_DEV "-dev") |
There was a problem hiding this comment.
PR scope mismatch: this is a version bump, not “add contributor” — please confirm intent.
The PR objectives describe adding a contributor, but these lines change the project’s versioning and dev suffix. If intentional, update the PR title/description accordingly; if not, this is likely an accidental/wrong-branch change.
🤖 Prompt for AI Agents
In CMakeLists.txt around lines 33 to 35, the changes modify the project version
and dev suffix (project(PGROUTING VERSION 4.1.0 LANGUAGES C CXX ) and
set(PROJECT_VERSION_DEV "-dev")) which conflicts with the PR description about
adding a contributor; confirm intent and either revert the version bump if it
was accidental (restore previous VERSION and PROJECT_VERSION_DEV values) or
update the PR title and description to state that this is a version bump (and
include a brief note about why the version was incremented). Ensure the branch
contains only changes relevant to the PR scope or split the version change into
a separate version-bump PR.
| @@ -1,14 +1,14 @@ | |||
| # SOME DESCRIPTIVE TITLE. | |||
| # Copyright (C) pgRouting Contributors - Version v3.8 | |||
| # Copyright (C) pgRouting Contributors - Version v4.1 | |||
There was a problem hiding this comment.
Drop #, fuzzy if these translations are meant to be “final”. The header still marks the catalog as fuzzy (Line 6), but you’re also updating Project-Id-Version and POT-Creation-Date (Lines 9–11). If this file is now regenerated/validated, remove the fuzzy flag so tooling doesn’t treat all strings as unreliable.
Also applies to: 9-11
🤖 Prompt for AI Agents
In locale/en/LC_MESSAGES/pgrouting_doc_strings.po around lines 2 and 9–11, the
PO header still contains the "#, fuzzy" marker which causes the catalog to be
treated as fuzzy despite updated Project-Id-Version and POT-Creation-Date;
remove the "#, fuzzy" flag from the header (and any occurrences in the
top-of-file header block) so the catalog is no longer marked fuzzy, ensure the
header fields Project-Id-Version and POT-Creation-Date remain correct, and save
the file so gettext tooling will treat the translations as final.
| ## pgRouting 4.1 | ||
|
|
||
|
|
||
|
|
||
| ### pgRouting 4.1.0 Release Notes | ||
|
|
||
| To see all issues & pull requests closed by this release see the | ||
| [#4.1.0](https://github.com/pgRouting/pgrouting/issues?utf8=%E2%9C%93&q=milestone%3A%22Release%204.1.0%22) | ||
|
|
||
| No changes yet | ||
|
|
There was a problem hiding this comment.
PR scope/title mismatch: this adds 4.1 release-note scaffolding, not just a contributor entry.
Please either (a) split into separate PRs (contributors-only vs release/versioning), or (b) update the PR title/description to reflect the 4.1.0 prep work included here.
4.1 section formatting looks fine as a placeholder.
| _pgr_array_reverse(anyarray) | ||
| _pgr_articulationpoints(text) | ||
| pgr_articulationpoints(text) | ||
| pgr_astarcostmatrix(text,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,anyarray,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,anyarray,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,bigint,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,bigint,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astarcost(text,text,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,anyarray,anyarray,boolean,integer,double precision,double precision) | ||
| _pgr_astar(text,anyarray,anyarray,boolean,integer,double precision,double precision,boolean,boolean) | ||
| pgr_astar(text,anyarray,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,bigint,anyarray,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,bigint,bigint,boolean,integer,double precision,double precision) | ||
| pgr_astar(text,text,boolean,integer,double precision,double precision) | ||
| _pgr_astar(text,text,boolean,integer,double precision,double precision,boolean) | ||
| _pgr_bandwidth(text) | ||
| pgr_bandwidth(text) | ||
| pgr_bdastarcostmatrix(text,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,anyarray,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,anyarray,bigint,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,bigint,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,bigint,bigint,boolean,integer,numeric,numeric) | ||
| pgr_bdastarcost(text,text,boolean,integer,numeric,numeric) | ||
| _pgr_bdastar(text,anyarray,anyarray,boolean,integer,double precision,double precision,boolean) | ||
| pgr_bdastar(text,anyarray,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastar(text,anyarray,bigint,boolean,integer,numeric,numeric) | ||
| pgr_bdastar(text,bigint,anyarray,boolean,integer,numeric,numeric) | ||
| pgr_bdastar(text,bigint,bigint,boolean,integer,numeric,numeric) | ||
| _pgr_bdastar(text,text,boolean,integer,double precision,double precision,boolean) | ||
| pgr_bdastar(text,text,boolean,integer,numeric,numeric) | ||
| pgr_bddijkstracostmatrix(text,anyarray,boolean) | ||
| pgr_bddijkstracost(text,anyarray,anyarray,boolean) | ||
| pgr_bddijkstracost(text,anyarray,bigint,boolean) | ||
| pgr_bddijkstracost(text,bigint,anyarray,boolean) | ||
| pgr_bddijkstracost(text,bigint,bigint,boolean) | ||
| pgr_bddijkstracost(text,text,boolean) | ||
| pgr_bddijkstra(text,anyarray,anyarray,boolean) | ||
| _pgr_bddijkstra(text,anyarray,anyarray,boolean,boolean) | ||
| pgr_bddijkstra(text,anyarray,bigint,boolean) | ||
| pgr_bddijkstra(text,bigint,anyarray,boolean) | ||
| pgr_bddijkstra(text,bigint,bigint,boolean) | ||
| pgr_bddijkstra(text,text,boolean) | ||
| _pgr_bddijkstra(text,text,boolean,boolean) | ||
| pgr_bellmanford(text,anyarray,anyarray,boolean) | ||
| _pgr_bellmanford(text,anyarray,anyarray,boolean,boolean) | ||
| pgr_bellmanford(text,anyarray,bigint,boolean) | ||
| pgr_bellmanford(text,bigint,anyarray,boolean) | ||
| pgr_bellmanford(text,bigint,bigint,boolean) | ||
| pgr_bellmanford(text,text,boolean) | ||
| _pgr_bellmanford(text,text,boolean,boolean) | ||
| _pgr_betweennesscentrality(text,boolean) | ||
| pgr_betweennesscentrality(text,boolean) | ||
| _pgr_biconnectedcomponents(text) | ||
| pgr_biconnectedcomponents(text) | ||
| _pgr_binarybreadthfirstsearch(text,anyarray,anyarray,boolean) | ||
| pgr_binarybreadthfirstsearch(text,anyarray,anyarray,boolean) | ||
| pgr_binarybreadthfirstsearch(text,anyarray,bigint,boolean) | ||
| pgr_binarybreadthfirstsearch(text,bigint,anyarray,boolean) | ||
| pgr_binarybreadthfirstsearch(text,bigint,bigint,boolean) | ||
| _pgr_binarybreadthfirstsearch(text,text,boolean) | ||
| pgr_binarybreadthfirstsearch(text,text,boolean) | ||
| _pgr_bipartite(text) | ||
| pgr_bipartite(text) | ||
| _pgr_boost_version() | ||
| pgr_boykovkolmogorov(text,anyarray,anyarray) | ||
| pgr_boykovkolmogorov(text,anyarray,bigint) | ||
| pgr_boykovkolmogorov(text,bigint,anyarray) | ||
| pgr_boykovkolmogorov(text,bigint,bigint) | ||
| pgr_boykovkolmogorov(text,text) | ||
| _pgr_breadthfirstsearch(text,anyarray,bigint,boolean) | ||
| pgr_breadthfirstsearch(text,anyarray,boolean,bigint) | ||
| pgr_breadthfirstsearch(text,bigint,boolean,bigint) | ||
| _pgr_bridges(text) | ||
| pgr_bridges(text) | ||
| _pgr_build_type() | ||
| _pgr_checkcolumn(text,text,text,boolean,boolean) | ||
| _pgr_checkquery(text) | ||
| pgr_chinesepostmancost(text) | ||
| pgr_chinesepostman(text) | ||
| _pgr_chinesepostman(text,boolean) | ||
| _pgr_compilation_date() | ||
| _pgr_compiler_version() | ||
| _pgr_connectedcomponents(text) | ||
| pgr_connectedcomponents(text) | ||
| pgr_contractiondeadend(text,boolean,bigint[]) | ||
| _pgr_contractionhierarchies(text,bigint[],boolean) | ||
| pgr_contractionhierarchies(text,boolean,bigint[]) | ||
| pgr_contractionlinear(text,boolean,bigint[]) | ||
| _pgr_contraction(text,bigint[],integer,bigint[],boolean) | ||
| pgr_contraction(text,boolean,integer[],integer,bigint[]) | ||
| _pgr_cuthillmckeeordering(text) | ||
| pgr_cuthillmckeeordering(text) | ||
| pgr_dagshortestpath(text,anyarray,anyarray) | ||
| pgr_dagshortestpath(text,anyarray,bigint) | ||
| pgr_dagshortestpath(text,bigint,anyarray) | ||
| pgr_dagshortestpath(text,bigint,bigint) | ||
| pgr_dagshortestpath(text,text) | ||
| _pgr_dagshortestpath_v4(text,anyarray,anyarray,boolean,boolean) | ||
| _pgr_dagshortestpath_v4(text,text,boolean) | ||
| pgr_degree(text,boolean) | ||
| pgr_degree(text,text,boolean) | ||
| _pgr_depthfirstsearch(text,anyarray,boolean,bigint) | ||
| pgr_depthfirstsearch(text,anyarray,boolean,bigint) | ||
| pgr_depthfirstsearch(text,bigint,boolean,bigint) | ||
| pgr_dijkstracostmatrix(text,anyarray,boolean) | ||
| pgr_dijkstracost(text,anyarray,anyarray,boolean) | ||
| pgr_dijkstracost(text,anyarray,bigint,boolean) | ||
| pgr_dijkstracost(text,bigint,anyarray,boolean) | ||
| pgr_dijkstracost(text,bigint,bigint,boolean) | ||
| pgr_dijkstracost(text,text,boolean) | ||
| pgr_dijkstranearcost(text,anyarray,anyarray,boolean,bigint,boolean) | ||
| pgr_dijkstranearcost(text,anyarray,bigint,boolean,bigint) | ||
| pgr_dijkstranearcost(text,bigint,anyarray,boolean,bigint) | ||
| pgr_dijkstranearcost(text,text,boolean,bigint,boolean) | ||
| pgr_dijkstranear(text,anyarray,anyarray,boolean,bigint,boolean) | ||
| pgr_dijkstranear(text,anyarray,bigint,boolean,bigint) | ||
| pgr_dijkstranear(text,bigint,anyarray,boolean,bigint) | ||
| pgr_dijkstranear(text,text,boolean,bigint,boolean) | ||
| pgr_dijkstra(text,anyarray,anyarray,boolean) | ||
| pgr_dijkstra(text,anyarray,bigint,boolean) | ||
| pgr_dijkstra(text,bigint,anyarray,boolean) | ||
| pgr_dijkstra(text,bigint,bigint,boolean) | ||
| pgr_dijkstra(text,text,boolean) | ||
| _pgr_dijkstra_v4(text,anyarray,anyarray,boolean,boolean,boolean,bigint,boolean) | ||
| _pgr_dijkstra_v4(text,text,boolean,boolean,bigint,boolean) | ||
| _pgr_dijkstravia(text,anyarray,boolean,boolean,boolean) | ||
| pgr_dijkstravia(text,anyarray,boolean,boolean,boolean) | ||
| pgr_drivingdistance(text,anyarray,double precision,boolean,boolean) | ||
| pgr_drivingdistance(text,bigint,double precision,boolean) | ||
| _pgr_drivingdistancev4(text,anyarray,double precision,boolean,boolean) | ||
| _pgr_edgecoloring(text) | ||
| pgr_edgecoloring(text) | ||
| _pgr_edgedisjointpaths(text,anyarray,anyarray,boolean) | ||
| pgr_edgedisjointpaths(text,anyarray,anyarray,boolean) | ||
| pgr_edgedisjointpaths(text,anyarray,bigint,boolean) | ||
| pgr_edgedisjointpaths(text,bigint,anyarray,boolean) | ||
| pgr_edgedisjointpaths(text,bigint,bigint,boolean) | ||
| _pgr_edgedisjointpaths(text,text,boolean) | ||
| pgr_edgedisjointpaths(text,text,boolean) | ||
| pgr_edmondskarp(text,anyarray,anyarray) | ||
| pgr_edmondskarp(text,anyarray,bigint) | ||
| pgr_edmondskarp(text,bigint,anyarray) | ||
| pgr_edmondskarp(text,bigint,bigint) | ||
| pgr_edmondskarp(text,text) | ||
| _pgr_edwardmoore(text,anyarray,anyarray,boolean) | ||
| pgr_edwardmoore(text,anyarray,anyarray,boolean) | ||
| pgr_edwardmoore(text,anyarray,bigint,boolean) | ||
| pgr_edwardmoore(text,bigint,anyarray,boolean) | ||
| pgr_edwardmoore(text,bigint,bigint,boolean) | ||
| _pgr_edwardmoore(text,text,boolean) | ||
| pgr_edwardmoore(text,text,boolean) | ||
| pgr_extractvertices(text,boolean) | ||
| pgr_findcloseedges(text,geometry,double precision,integer,boolean) | ||
| pgr_findcloseedges(text,geometry[],double precision,integer,boolean) | ||
| _pgr_floydwarshall(text,boolean) | ||
| pgr_floydwarshall(text,boolean) | ||
| pgr_full_version() | ||
| _pgr_get_statement(text) | ||
| _pgr_git_hash() | ||
| _pgr_hawickcircuits(text) | ||
| pgr_hawickcircuits(text) | ||
| _pgr_isplanar(text) | ||
| pgr_isplanar(text) | ||
| _pgr_johnson(text,boolean) | ||
| pgr_johnson(text,boolean) | ||
| _pgr_kingordering(text) | ||
| pgr_kingordering(text) | ||
| pgr_kruskalbfs(text,anyarray,bigint) | ||
| pgr_kruskalbfs(text,bigint,bigint) | ||
| pgr_kruskaldd(text,anyarray,double precision) | ||
| pgr_kruskaldd(text,anyarray,numeric) | ||
| pgr_kruskaldd(text,bigint,double precision) | ||
| pgr_kruskaldd(text,bigint,numeric) | ||
| pgr_kruskaldfs(text,anyarray,bigint) | ||
| pgr_kruskaldfs(text,bigint,bigint) | ||
| pgr_kruskal(text) | ||
| _pgr_kruskalv4(text,anyarray,text,bigint,double precision) | ||
| pgr_ksp(text,anyarray,anyarray,integer,boolean,boolean) | ||
| pgr_ksp(text,anyarray,bigint,integer,boolean,boolean) | ||
| pgr_ksp(text,bigint,anyarray,integer,boolean,boolean) | ||
| pgr_ksp(text,bigint,bigint,integer,boolean,boolean) | ||
| pgr_ksp(text,text,integer,boolean,boolean) | ||
| _pgr_ksp_v4(text,anyarray,anyarray,integer,boolean,boolean) | ||
| _pgr_ksp_v4(text,text,integer,boolean,boolean) | ||
| _pgr_lengauertarjandominatortree(text,bigint) | ||
| pgr_lengauertarjandominatortree(text,bigint) | ||
| _pgr_lib_version() | ||
| _pgr_linegraphfull(text) | ||
| pgr_linegraphfull(text) | ||
| _pgr_linegraph(text,boolean) | ||
| pgr_linegraph(text,boolean) | ||
| _pgr_makeconnected(text) | ||
| pgr_makeconnected(text) | ||
| pgr_maxcardinalitymatch(text) | ||
| _pgr_maxcardinalitymatch_v4(text) | ||
| pgr_maxflowmincost_cost(text,anyarray,anyarray) | ||
| pgr_maxflowmincost_cost(text,anyarray,bigint) | ||
| pgr_maxflowmincost_cost(text,bigint,anyarray) | ||
| pgr_maxflowmincost_cost(text,bigint,bigint) | ||
| pgr_maxflowmincost_cost(text,text) | ||
| pgr_maxflowmincost(text,anyarray,anyarray) | ||
| _pgr_maxflowmincost(text,anyarray,anyarray,boolean) | ||
| pgr_maxflowmincost(text,anyarray,bigint) | ||
| pgr_maxflowmincost(text,bigint,anyarray) | ||
| pgr_maxflowmincost(text,bigint,bigint) | ||
| pgr_maxflowmincost(text,text) | ||
| _pgr_maxflowmincost(text,text,boolean) | ||
| pgr_maxflow(text,anyarray,anyarray) | ||
| _pgr_maxflow(text,anyarray,anyarray,integer,boolean) | ||
| pgr_maxflow(text,anyarray,bigint) | ||
| pgr_maxflow(text,bigint,anyarray) | ||
| pgr_maxflow(text,bigint,bigint) | ||
| pgr_maxflow(text,text) | ||
| _pgr_maxflow(text,text,integer,boolean) | ||
| _pgr_operating_system() | ||
| _pgr_parameter_check(text,text,boolean) | ||
| _pgr_pgsql_version() | ||
| _pgr_pickdelivereuclidean(text,text,double precision,integer,integer) | ||
| pgr_pickdelivereuclidean(text,text,double precision,integer,integer) | ||
| _pgr_pickdeliver(text,text,text,double precision,integer,integer) | ||
| pgr_pickdeliver(text,text,text,double precision,integer,integer) | ||
| pgr_primbfs(text,anyarray,bigint) | ||
| pgr_primbfs(text,bigint,bigint) | ||
| pgr_primdd(text,anyarray,double precision) | ||
| pgr_primdd(text,anyarray,numeric) | ||
| pgr_primdd(text,bigint,double precision) | ||
| pgr_primdd(text,bigint,numeric) | ||
| pgr_primdfs(text,anyarray,bigint) | ||
| pgr_primdfs(text,bigint,bigint) | ||
| pgr_prim(text) | ||
| _pgr_primv4(text,anyarray,text,bigint,double precision) | ||
| pgr_pushrelabel(text,anyarray,anyarray) | ||
| pgr_pushrelabel(text,anyarray,bigint) | ||
| pgr_pushrelabel(text,bigint,anyarray) | ||
| pgr_pushrelabel(text,bigint,bigint) | ||
| pgr_pushrelabel(text,text) | ||
| pgr_separatecrossing(text,double precision,boolean) | ||
| pgr_separatetouching(text,double precision,boolean) | ||
| _pgr_sequentialvertexcoloring(text) | ||
| pgr_sequentialvertexcoloring(text) | ||
| _pgr_sloanordering(text) | ||
| pgr_sloanordering(text) | ||
| _pgr_stoerwagner(text) | ||
| pgr_stoerwagner(text) | ||
| _pgr_strongcomponents(text) | ||
| pgr_strongcomponents(text) | ||
| _pgr_topologicalsort(text) | ||
| pgr_topologicalsort(text) | ||
| _pgr_transitiveclosure(text) | ||
| pgr_transitiveclosure(text) | ||
| pgr_trsp(text,text,anyarray,anyarray,boolean) | ||
| pgr_trsp(text,text,anyarray,bigint,boolean) | ||
| pgr_trsp(text,text,bigint,anyarray,boolean) | ||
| pgr_trsp(text,text,bigint,bigint,boolean) | ||
| pgr_trsp(text,text,text,boolean) | ||
| _pgr_trspv4(text,text,anyarray,anyarray,boolean) | ||
| _pgr_trspv4(text,text,text,boolean) | ||
| _pgr_trspvia(text,text,anyarray,boolean,boolean,boolean) | ||
| pgr_trspvia(text,text,anyarray,boolean,boolean,boolean) | ||
| pgr_trspvia_withpoints(text,text,text,anyarray,boolean,boolean,boolean,boolean) | ||
| pgr_trspvia_withpoints(text,text,text,anyarray,character,boolean,boolean,boolean,boolean) | ||
| _pgr_trspvia_withpoints_v4(text,text,text,anyarray,boolean,boolean,boolean,character,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,anyarray,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,anyarray,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,bigint,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,anyarray,bigint,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,anyarray,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,anyarray,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,bigint,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,bigint,bigint,character,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,text,boolean,boolean) | ||
| pgr_trsp_withpoints(text,text,text,text,character,boolean,boolean) | ||
| _pgr_trsp_withpoints_v4(text,text,text,anyarray,anyarray,boolean,character,boolean) | ||
| _pgr_trsp_withpoints_v4(text,text,text,text,boolean,character,boolean) | ||
| pgr_tspeuclidean(text,bigint,bigint) | ||
| _pgr_tspeuclidean_v4(text,bigint,bigint) | ||
| pgr_tsp(text,bigint,bigint) | ||
| _pgr_tsp_v4(text,bigint,bigint) | ||
| pgr_turnrestrictedpath(text,text,bigint,bigint,integer,boolean,boolean,boolean,boolean) | ||
| _pgr_turnrestrictedpath_v4(text,text,anyarray,anyarray,integer,boolean,boolean,boolean,boolean) | ||
| pgr_version() | ||
| _pgr_vrponedepot(text,text,text,integer) | ||
| pgr_vrponedepot(text,text,text,integer) | ||
| pgr_withpointscostmatrix(text,text,anyarray,boolean) | ||
| pgr_withpointscostmatrix(text,text,anyarray,character,boolean) | ||
| pgr_withpointscost(text,text,anyarray,anyarray,boolean) | ||
| pgr_withpointscost(text,text,anyarray,anyarray,character,boolean) | ||
| pgr_withpointscost(text,text,anyarray,bigint,boolean) | ||
| pgr_withpointscost(text,text,anyarray,bigint,character,boolean) | ||
| pgr_withpointscost(text,text,bigint,anyarray,boolean) | ||
| pgr_withpointscost(text,text,bigint,anyarray,character,boolean) | ||
| pgr_withpointscost(text,text,bigint,bigint,boolean) | ||
| pgr_withpointscost(text,text,bigint,bigint,character,boolean) | ||
| pgr_withpointscost(text,text,text,boolean) | ||
| pgr_withpointscost(text,text,text,character,boolean) | ||
| pgr_withpointsdd(text,text,anyarray,double precision,boolean,boolean,boolean) | ||
| pgr_withpointsdd(text,text,anyarray,double precision,character,boolean,boolean,boolean) | ||
| pgr_withpointsdd(text,text,bigint,double precision,boolean,boolean) | ||
| pgr_withpointsdd(text,text,bigint,double precision,character,boolean,boolean) | ||
| _pgr_withpointsddv4(text,text,anyarray,double precision,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,anyarray,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,anyarray,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,bigint,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,anyarray,bigint,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,anyarray,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,anyarray,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,bigint,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,bigint,bigint,integer,character,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,text,integer,boolean,boolean,boolean) | ||
| pgr_withpointsksp(text,text,text,integer,character,boolean,boolean,boolean) | ||
| _pgr_withpointsksp_v4(text,text,anyarray,anyarray,integer,character,boolean,boolean,boolean) | ||
| _pgr_withpointsksp_v4(text,text,text,integer,character,boolean,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,anyarray,boolean,boolean) | ||
| _pgr_withpoints(text,text,anyarray,anyarray,boolean,character,boolean,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,anyarray,character,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,bigint,boolean,boolean) | ||
| pgr_withpoints(text,text,anyarray,bigint,character,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,anyarray,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,anyarray,character,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,bigint,boolean,boolean) | ||
| pgr_withpoints(text,text,bigint,bigint,character,boolean,boolean) | ||
| pgr_withpoints(text,text,text,boolean,boolean) | ||
| _pgr_withpoints(text,text,text,boolean,character,boolean,boolean) | ||
| pgr_withpoints(text,text,text,character,boolean,boolean) | ||
| _pgr_withpoints_v4(text,text,anyarray,anyarray,boolean,character,boolean,boolean,boolean,bigint,boolean) | ||
| _pgr_withpoints_v4(text,text,text,boolean,character,boolean,boolean,bigint,boolean) | ||
| pgr_withpointsvia(text,text,anyarray,boolean,boolean,boolean,boolean) | ||
| pgr_withpointsvia(text,text,anyarray,character,boolean,boolean,boolean,boolean) | ||
| _pgr_withpointsvia_v4(text,text,anyarray,boolean,boolean,boolean,character,boolean) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if this is a new file or modification
echo "=== File Status ==="
git log --oneline -n 5 sql/sigs/pgrouting--4.1.sig 2>/dev/null || echo "File may be new"
# Check if signature files exist for other versions
echo -e "\n=== Signature Files in Repository ==="
find sql/sigs -name "pgrouting--*.sig" -type f | sort
# Get file metadata
echo -e "\n=== File Metadata ==="
wc -l sql/sigs/pgrouting--4.1.sig
file sql/sigs/pgrouting--4.1.sig
# Check for CREATE FUNCTION statements in SQL files
echo -e "\n=== Total CREATE FUNCTION statements ==="
rg "CREATE.*FUNCTION\s+(pgr_|_pgr_)" --type=sql 2>/dev/null | wc -l
# Sample a few function definitions to understand the format
echo -e "\n=== Sample CREATE FUNCTION statements ==="
rg "CREATE.*FUNCTION\s+(pgr_|_pgr_)" --type=sql -A 1 2>/dev/null | head -20Repository: pgRouting/GSoC-pgRouting
Length of output: 1533
🏁 Script executed:
#!/bin/bash
# Extract function names from signature file
echo "=== Functions in Signature File ==="
sed 's/(.*//g' sql/sigs/pgrouting--4.1.sig | sort | uniq > /tmp/sig_functions.txt
wc -l /tmp/sig_functions.txt
# Extract unique CREATE FUNCTION names from SQL
echo -e "\n=== Functions in SQL CREATE FUNCTION Statements ==="
rg "CREATE.*FUNCTION\s+(pgr_|_pgr_)\w+" --type=sql -o | sed 's/.*FUNCTION\s*//g' | sort | uniq > /tmp/sql_functions.txt
wc -l /tmp/sql_functions.txt
# Compare - functions in signature file but not in SQL
echo -e "\n=== Functions in Signature but NOT in SQL ==="
comm -23 /tmp/sig_functions.txt /tmp/sql_functions.txt | head -20
# Compare - functions in SQL but not in signature file
echo -e "\n=== Functions in SQL but NOT in Signature ==="
comm -13 /tmp/sig_functions.txt /tmp/sql_functions.txt | head -20
# Show statistics
echo -e "\n=== Comparison Summary ==="
echo "Unique signatures: $(wc -l < /tmp/sig_functions.txt)"
echo "Unique SQL functions: $(wc -l < /tmp/sql_functions.txt)"
echo "In sig only: $(comm -23 /tmp/sig_functions.txt /tmp/sql_functions.txt | wc -l)"
echo "In SQL only: $(comm -13 /tmp/sig_functions.txt /tmp/sql_functions.txt | wc -l)"Repository: pgRouting/GSoC-pgRouting
Length of output: 1267
🏁 Script executed:
#!/bin/bash
# Let's check for the missing functions more carefully
echo "=== Functions completely missing from signature file ==="
echo "Looking for functions in SQL that don't have even a lowercase variant in signature..."
# Create case-insensitive comparison
rg "CREATE.*FUNCTION\s+(pgr_|_pgr_)\w+" --type=sql -o | sed 's/.*FUNCTION\s*//g' | tr '[:upper:]' '[:lower:]' | sort | uniq > /tmp/sql_functions_lower.txt
sed 's/(.*//g' sql/sigs/pgrouting--4.1.sig | tr '[:upper:]' '[:lower:]' | sort | uniq > /tmp/sig_functions_lower.txt
echo "=== Functions in SQL (case-insensitive) but NOT in Signature ==="
comm -13 /tmp/sig_functions_lower.txt /tmp/sql_functions_lower.txt
# Check specifically for boyerMyrvold and bellmanFordNeg
echo -e "\n=== Checking for boyerMyrvold function ==="
rg "boyerMyrvold" --type=sql -A 5
echo -e "\n=== Checking for bellmanFordNeg function ==="
rg "bellmanFordNeg" --type=sql -A 5
# Verify the signature file format is correct
echo -e "\n=== Sample from signature file to verify format ==="
head -5 sql/sigs/pgrouting--4.1.sigRepository: pgRouting/GSoC-pgRouting
Length of output: 5973
Signature file is incomplete and missing 5 exported functions.
The signature file for pgRouting 4.1 is missing the following functions that are defined in SQL:
_pgr_bellmanFordNeg(text, text, anyarray, anyarray, boolean, boolean)— internal Bellman-Ford variant for negative edgespgr_boyerMyrvold(text)— planar graph planarity testing function_pgr_boyerMyrvold(text)— internal planarity functionpgr_randomspantree(text, bigint)— random spanning tree function_pgr_randomspantree(text, bigint)— internal random spanning tree function
Add these function signatures to ensure the 4.1 signature file is complete and consistent with the actual exported API.
4 participants
Task 2: Added my name to contributors list
@pgRouting/admins
Summary by CodeRabbit
Release Notes
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.