Skip to content

fix: Preserve physics group config with existing children #7322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Farley-Chen wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −10
Open

fix: Preserve physics group config with existing children #7322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/physics/arcade/PhysicsGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,10 @@ var PhysicsGroup = new Class({
}
else
{
// config is not defined and children is not a plain object nor an array of plain objects
config = {
internalCreateCallback: this.createCallbackHandler,
internalRemoveCallback: this.removeCallbackHandler
};
// children is not a plain object nor an array of plain objects
config = config || {};
config.internalCreateCallback = this.createCallbackHandler;
config.internalRemoveCallback = this.removeCallbackHandler;
}

/**
Expand Down
9 changes: 4 additions & 5 deletions src/physics/arcade/StaticPhysicsGroup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,10 @@ var StaticPhysicsGroup = new Class({
}
else
{
// config is not defined and children is not a plain object nor an array of plain objects
config = {
internalCreateCallback: this.createCallbackHandler,
internalRemoveCallback: this.removeCallbackHandler
};
// children is not a plain object nor an array of plain objects
config = config || {};
config.internalCreateCallback = this.createCallbackHandler;
config.internalRemoveCallback = this.removeCallbackHandler;
}

/**
Expand Down