Skip to content

Preserve PATH in filter OOM tests for Windows ASan - #25163

Merged
shivammathur merged 1 commit into
php:PHP-8.4from
shivammathur:windows-asan-filter-oom-path
Nov 2, 2026
Merged

shivammathur merged 1 commit into
php:PHP-8.4from
shivammathur:windows-asan-filter-oom-path

Conversation

@shivammathur

Copy link
Copy Markdown
Member

Fix nightly CI for Windows. For ASan builds, it needs PATH to find the ASan runtime DLL.
https://github.com/php/php-src/actions/runs/41371305150/job/125042476161#step:6:669

Ref: GH-17079

@iluuu1994 iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shivam

@shivammathur
shivammathur merged commit 4dece75 into php:PHP-8.4 Nov 2, 2026
18 checks passed
shivammathur added a commit that referenced this pull request Nov 2, 2026
* PHP-8.6:
  Preserve PATH in filter OOM tests for Windows ASan (#25163)
kairosci pushed a commit to kairosci/php-src that referenced this pull request Nov 2, 2026
* PHP-8.4:
  Preserve PATH in filter OOM tests for Windows ASan (php#25163)
kairosci pushed a commit to kairosci/php-src that referenced this pull request Nov 2, 2026
* PHP-8.5:
  Preserve PATH in filter OOM tests for Windows ASan (php#25163)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants