Skip to content

Fix inconsistencies #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iMattPro merged 1 commit into from
Aug 12, 2026
Merged

Fix inconsistencies #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"role": "Extensions Development Team Lead"
},
{
"name": "Vinny",
"role": "Customisations Team"
"name": "Vinny",
"role": "Customisations Team"
}
],
"require": {
Expand Down
4 changes: 2 additions & 2 deletions migrations/add_popup_prompt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class add_popup_prompt extends migration
{
public function effectively_installed()
public function effectively_installed(): bool
{
return $this->config->offsetExists('wpn_webpush_popup_prompt');
}
Expand All @@ -24,7 +24,7 @@ public static function depends_on()
return ['\phpbb\webpushnotifications\migrations\add_acp_configs'];
}

public function update_data()
public function update_data(): array
{
return [
['config.add', ['wpn_webpush_popup_prompt', 0]],
Expand Down
6 changes: 3 additions & 3 deletions migrations/add_user_popup_preference.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class add_user_popup_preference extends migration
{
public function effectively_installed()
public function effectively_installed(): bool
{
return $this->db_tools->sql_column_exists($this->table_prefix . 'users', 'user_wpn_popup_disabled');
}
Expand All @@ -24,7 +24,7 @@ public static function depends_on()
return ['\phpbb\webpushnotifications\migrations\add_popup_prompt'];
}

public function update_schema()
public function update_schema(): array
{
return [
'add_columns' => [
Expand All @@ -35,7 +35,7 @@ public function update_schema()
];
}

public function revert_schema()
public function revert_schema(): array
{
return [
'drop_columns' => [
Expand Down
2 changes: 1 addition & 1 deletion migrations/fix_acp_module_auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

class fix_acp_module_auth extends migration
{
public function effectively_installed()
public function effectively_installed(): bool
{
$sql = 'SELECT module_id
FROM ' . $this->table_prefix . "modules
Expand Down
2 changes: 1 addition & 1 deletion migrations/handle_subscriptions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public static function depends_on()
return ['\phpbb\webpushnotifications\migrations\add_webpush'];
}

public function effectively_installed()
public function effectively_installed(): bool
{
return !$this->db_tools->sql_table_exists($this->table_prefix . 'wpn_notification_push');
}
Expand Down
2 changes: 1 addition & 1 deletion migrations/setup_site_icons.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class setup_site_icons extends container_aware_migration
/** @var filesystem $filesystem */
private $filesystem;

public function effectively_installed()
public function effectively_installed(): bool
{
return $this->get_filesystem()->exists($this->container->getParameter('core.root_path') . self::NEW_ICON_DIR);
}
Expand Down