MutatingScope: Remove unnecessary union #4780
Closed
+6
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jan 18, 2026
Comment on lines
-3346
to
-3355
| $types = [ | ||
| new ArrayType(new MixedType(), new MixedType()), | ||
| new ObjectType(ArrayAccess::class), | ||
| new NullType(), | ||
| ]; | ||
| if ($dimType->isInteger()->yes()) { | ||
| $types[] = new StringType(); | ||
| } | ||
| $offsetValueType = TypeCombinator::intersect($exprVarType, TypeCombinator::union(...$types)); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
the actual change is here.
I am not sure why this no longer makes a difference.. maybe related to Type->setExistingOffset() and friends
staabm
commented
Jan 18, 2026
Comment on lines
79
to
90
| if ($type instanceof CompoundType) { | ||
| return $type->isAcceptedBy($this, $strictTypes); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
this is #4766 which makes sense on its own
clxmstaab
force-pushed
the
remove-union
branch
from
ad53698 to
8f73a13
Compare
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
ok - lets see what you think about it. in case you are fine with the change I can add regression tests for the issue-bot reports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the 3rd time this week, which made me think that I need #4766 to implement some other stuff.
Lets see how you feel about it :-)