Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #20493

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. labels Dec 25, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 25, 2025
16 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for the Backup & Restore (BR) tool by providing a more detailed and granular visualization of both backup and restore operations. The changes aim to improve user understanding of the progress and underlying processes during these critical database operations, making the documentation more informative and user-friendly.

Highlights

  • Improved Restore Progress Visualization: The documentation now reflects a more granular breakdown of the restore process, replacing a single 'Full Restore' progress bar with 'Split&Scatter Region', 'Download&Ingest SST', and 'Restore Pipeline' steps, offering better insight into the restore operation's stages.
  • Enhanced Backup Statistics Explanation: New explanations have been added for various backup statistics, including total-ranges, ranges-succeed, ranges-failed, backup-total-ranges, write-CF-files, and default-CF-files, providing a clearer understanding of backup summary outputs.
  • Detailed Restore Statistics Explanation: The documentation now includes detailed descriptions for restore statistics such as total-ranges, ranges-succeed, ranges-failed, merge-ranges, split-region, restore-files, write-CF-files, default-CF-files, and split-keys, aiding users in interpreting restore summary information.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lilin90 lilin90 assigned lilin90 and unassigned Leavrth Dec 25, 2025
@lilin90 lilin90 requested a review from Leavrth December 25, 2025 09:20
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the visualization of Backup & Restore (BR) operations by updating the progress bar display for restore tasks and adding more detailed metrics to the summary outputs. The changes enhance clarity for users monitoring backup and restore processes. My review focuses on improving the readability and conciseness of the new documentation, in line with the repository's style guide. I've suggested replacing ampersands with 'and' for a more formal tone and rephrasing metric descriptions to be more direct.

@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2025
@lilin90 lilin90 changed the title br: improve visualization of BR (#20493) v8.5.5 br: improve visualization of BR (#20493) Dec 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants