i18n(ja): fix broken multiplication-sign spacing in cost-model.md - #23605
Conversation
The markdownlint MD037 auto-fix in pingcap#23602 misidentified the literal multiplication asterisk as emphasis markup and stripped the surrounding spaces, producing "20* 8" instead of "20 * 8". Escapes the first asterisk (matching the English source) so markdownlint no longer treats it as emphasis.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughインデックス Changesインデックスコスト計算例
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation change restores readable multiplication-sign spacing without introducing actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description explains the regression, identifies the fix, specifies the affected Japanese 8.5 documentation version, and includes a related reference. Optional checklist sections are omitted, but the required content is complete. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rebased onto i18n-ja-release-8.5 after pingcap#23602 merged the markdownlint conformance fixes. Also escaped a literal multiplication asterisk formula in statement-summary-tables.md that was already failing MD037 in the pre-rebase branch (same class of issue as pingcap#23605's cost-model.md fix), matching how the English source escapes it.
[LGTM Timeline notifier]Timeline:
|
Rebased onto i18n-ja-release-8.5 after pingcap#23602 merged the markdownlint conformance fixes. Also escaped a literal multiplication asterisk formula in statement-summary-tables.md that was already failing MD037 in the pre-rebase branch (same class of issue as pingcap#23605's cost-model.md fix), matching how the English source escapes it.
What is changed, added or deleted? (Required)
Fixes a regression introduced by #23602's automated MD037 (no-space-in-emphasis) fix: it misidentified the literal multiplication asterisk in the index-cost formula as Markdown emphasis markup and stripped the surrounding spaces, turning
20 * 8into20* 8.This escapes the first asterisk in each formula (
\*), matching how the English source (cost-model.md) already escapes it, so markdownlint no longer treats it as emphasis while keeping the formula readable.Found while reviewing/rebasing PR #23594.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?
Summary by CodeRabbit