Skip to content

feat: Add Kiro editor support to open picker#1974

Merged
juliusmarminge merged 1 commit intopingdotgg:mainfrom
ashvinnihalani:t3code/kiro-ghost-logo-fix
Apr 13, 2026
Merged

feat: Add Kiro editor support to open picker#1974
juliusmarminge merged 1 commit intopingdotgg:mainfrom
ashvinnihalani:t3code/kiro-ghost-logo-fix

Conversation

@ashvinnihalani
Copy link
Copy Markdown
Contributor

@ashvinnihalani ashvinnihalani commented Apr 13, 2026

What Changed

  • add Kiro to shared editor definitions and launch args
  • surface Kiro in the web picker with icon
  • cover command resolution and picker flow with tests

Why

Kiro is enterprise editor that has wide-spread adoption across the industry

UI Changes

Add the Kiro UI icon the the open drop down

Checklist

  • This PR is small and focused
  • [ X] I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Low risk: adds a new editor option and a small change to editor launch argument construction, with coverage added in server and browser tests.

Overview
Adds Kiro as a supported editor across the stack: a new EDITORS entry (with baseArgs: ["ide"]) and UI picker option (including a new KiroIcon).

Updates server launch resolution to prepend optional per-editor baseArgs via resolveEditorArgs, and extends test coverage to verify Kiro command/args resolution and that the web open picker sends shellOpenInEditor with editor: "kiro".

Reviewed by Cursor Bugbot for commit db0a7f3. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add Kiro editor to the open picker

Macroscope summarized db0a7f3.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1d0c14d9-36cb-4d91-a3fd-ba51096dfdae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ashvinnihalani
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-04-12 at 9 34 30 PM

@github-actions github-actions bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Apr 13, 2026
macroscopeapp[bot]
macroscopeapp bot previously approved these changes Apr 13, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 13, 2026

Approvability

Verdict: Approved

Straightforward additive change that adds Kiro editor support to the existing open picker, following established patterns. Includes comprehensive tests, a new icon, and minor type extension for base arguments. No runtime behavior changes to existing functionality.

You can customize Macroscope's approvability policy. Learn more.

Comment thread apps/server/src/open.ts Outdated
@macroscopeapp macroscopeapp bot dismissed their stale review April 13, 2026 18:59

Dismissing prior approval to re-evaluate 09e4e01

@ashvinnihalani ashvinnihalani force-pushed the t3code/kiro-ghost-logo-fix branch 2 times, most recently from 1ef427c to 1190d7e Compare April 13, 2026 19:06
@ashvinnihalani
Copy link
Copy Markdown
Contributor Author

Rebased off main and everyhting still works

Co-authored-by: Julius Marminge <jmarminge@gmail.com>
@ashvinnihalani ashvinnihalani force-pushed the t3code/kiro-ghost-logo-fix branch from d6447cd to db0a7f3 Compare April 13, 2026 19:12
@juliusmarminge juliusmarminge enabled auto-merge (squash) April 13, 2026 19:14
@juliusmarminge juliusmarminge merged commit 5f7becf into pingdotgg:main Apr 13, 2026
10 checks passed
juliusmarminge added a commit that referenced this pull request Apr 13, 2026
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
smraikai pushed a commit to smraikai/t3code that referenced this pull request Apr 16, 2026
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Apr 16, 2026
Integrates upstream/main (d22c6f5) into the fork while preserving all
multi-provider support (codex, claudeAgent, copilot, cursor, opencode,
geminiCli, amp, kilo) and fork UI/UX additions.

Highlights adopted from upstream:
- Nightly release channel + update channel selector (pingdotgg#2012, pingdotgg#2049, pingdotgg#1969)
- Filesystem browse API + command palette project picker (pingdotgg#2024)
- Launch Args setting for Claude provider (pingdotgg#1971)
- Kiro editor support in open picker (pingdotgg#1974)
- Claude plan events for TodoWrite during input streaming (pingdotgg#1541)
- Lost provider session recovery (pingdotgg#1938)
- Cache provider status and gate desktop startup (pingdotgg#1962)
- LegendList migration for chat scrolling and branch lists (pingdotgg#1953)
- Shell snapshot queries + backfill migration (pingdotgg#1973, pingdotgg#2004)
- PATH hydration + fallback detection (pingdotgg#1799)
- Warm sidebar thread subscriptions (pingdotgg#2001)
- Full thread title tooltip (pingdotgg#1994)
- Markdown file link UX (pingdotgg#1956), composer polish (pingdotgg#1944, pingdotgg#1992, pingdotgg#1985)
- Worktree/branch state + draft reuse fixes (pingdotgg#2005, pingdotgg#2003, pingdotgg#1995, pingdotgg#1936)
- Window controls overlay for Windows/Linux (pingdotgg#1969)
- Backend readiness timeout 10s→30s (pingdotgg#1979)
- Clear tracked RPCs on reconnect, live stream subscriptions (pingdotgg#2000, pingdotgg#1972)
- Various misc fixes (pingdotgg#2051, pingdotgg#2052, pingdotgg#2025, pingdotgg#2027, pingdotgg#2049, pingdotgg#1997, pingdotgg#1975)

Fork features preserved and reconciled:
- All 8 provider adapters + conformance tests
- Extended ProviderKind union across contracts/model/settings/provider
- appearance/accentColor/themeConfig/ProviderLogo UI system
- customModels + gitTextGeneration + providerModelOptions
- Migration IDs 23 (NormalizeLegacyProviderKinds) and 24
  (RepairProjectionThreadProposedPlanImplementationColumns) kept; new
  upstream migrations registered at IDs 25-26 to avoid breaking deployed
  fork databases
- DesktopBridge: log directory channels (LOG_DIR/LIST/READ/OPEN_DIR)
  retained; getWsUrl replaced by upstream's getAppBranding
- PROVIDER_CACHE_IDS extended to all 8 providers
znoraka pushed a commit to znoraka/t3code that referenced this pull request Apr 17, 2026
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants