feat: Add Kiro editor support to open picker#1974
feat: Add Kiro editor support to open picker#1974juliusmarminge merged 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Straightforward additive change that adds Kiro editor support to the existing open picker, following established patterns. Includes comprehensive tests, a new icon, and minor type extension for base arguments. No runtime behavior changes to existing functionality. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 09e4e01
1ef427c to
1190d7e
Compare
|
Rebased off main and everyhting still works |
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
d6447cd to
db0a7f3
Compare
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Integrates upstream/main (d22c6f5) into the fork while preserving all multi-provider support (codex, claudeAgent, copilot, cursor, opencode, geminiCli, amp, kilo) and fork UI/UX additions. Highlights adopted from upstream: - Nightly release channel + update channel selector (pingdotgg#2012, pingdotgg#2049, pingdotgg#1969) - Filesystem browse API + command palette project picker (pingdotgg#2024) - Launch Args setting for Claude provider (pingdotgg#1971) - Kiro editor support in open picker (pingdotgg#1974) - Claude plan events for TodoWrite during input streaming (pingdotgg#1541) - Lost provider session recovery (pingdotgg#1938) - Cache provider status and gate desktop startup (pingdotgg#1962) - LegendList migration for chat scrolling and branch lists (pingdotgg#1953) - Shell snapshot queries + backfill migration (pingdotgg#1973, pingdotgg#2004) - PATH hydration + fallback detection (pingdotgg#1799) - Warm sidebar thread subscriptions (pingdotgg#2001) - Full thread title tooltip (pingdotgg#1994) - Markdown file link UX (pingdotgg#1956), composer polish (pingdotgg#1944, pingdotgg#1992, pingdotgg#1985) - Worktree/branch state + draft reuse fixes (pingdotgg#2005, pingdotgg#2003, pingdotgg#1995, pingdotgg#1936) - Window controls overlay for Windows/Linux (pingdotgg#1969) - Backend readiness timeout 10s→30s (pingdotgg#1979) - Clear tracked RPCs on reconnect, live stream subscriptions (pingdotgg#2000, pingdotgg#1972) - Various misc fixes (pingdotgg#2051, pingdotgg#2052, pingdotgg#2025, pingdotgg#2027, pingdotgg#2049, pingdotgg#1997, pingdotgg#1975) Fork features preserved and reconciled: - All 8 provider adapters + conformance tests - Extended ProviderKind union across contracts/model/settings/provider - appearance/accentColor/themeConfig/ProviderLogo UI system - customModels + gitTextGeneration + providerModelOptions - Migration IDs 23 (NormalizeLegacyProviderKinds) and 24 (RepairProjectionThreadProposedPlanImplementationColumns) kept; new upstream migrations registered at IDs 25-26 to avoid breaking deployed fork databases - DesktopBridge: log directory channels (LOG_DIR/LIST/READ/OPEN_DIR) retained; getWsUrl replaced by upstream's getAppBranding - PROVIDER_CACHE_IDS extended to all 8 providers
Co-authored-by: Julius Marminge <jmarminge@gmail.com>

What Changed
Why
Kiro is enterprise editor that has wide-spread adoption across the industry
UI Changes
Add the Kiro UI icon the the open drop down
Checklist
Note
Low Risk
Low risk: adds a new editor option and a small change to editor launch argument construction, with coverage added in server and browser tests.
Overview
Adds Kiro as a supported editor across the stack: a new
EDITORSentry (withbaseArgs: ["ide"]) and UI picker option (including a newKiroIcon).Updates server launch resolution to prepend optional per-editor
baseArgsviaresolveEditorArgs, and extends test coverage to verify Kiro command/args resolution and that the web open picker sendsshellOpenInEditorwitheditor: "kiro".Reviewed by Cursor Bugbot for commit db0a7f3. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add Kiro editor to the open picker
kiroeditor entry inpackages/contracts/src/editor.tswith commandkiro,baseArgs: ['ide'], andlaunchStyle: 'goto'.EditorDefinitionwith an optionalbaseArgsfield and updatesresolveEditorArgsinapps/server/src/open.tsto prepend these args when building launch commands.KiroIconSVG component and a'kiro'option to the Open picker inapps/web/src/components/chat/OpenInPicker.tsxso Kiro appears when reported as available by the server.Macroscope summarized db0a7f3.