Skip to content

[codex] Report preview action failures#3351

Merged
juliusmarminge merged 6 commits into
codex/redact-dpop-request-targetfrom
codex/web-preview-action-errors
Jun 20, 2026
Merged

[codex] Report preview action failures#3351
juliusmarminge merged 6 commits into
codex/redact-dpop-request-targetfrom
codex/web-preview-action-errors

Conversation

@juliusmarminge

@juliusmarminge juliusmarminge commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary

  • report previously swallowed preview bridge and local API failures with operation, thread, tab, artifact, and annotation context
  • preserve the exact upstream cause so original stack chains remain available
  • replace raw preview URLs in logged context with hostname, protocol, and input length
  • cover credential, path-token, query-token, and fragment redaction with a focused regression test

Stack dependency

Validation

  • vp test run apps/web/src/components/preview/reportPreviewActionFailure.test.ts (1 test)
  • vp check (passes with 20 pre-existing warnings)
  • vp run typecheck

Note

Low Risk
Observability-only change: user-visible behavior and toasts are largely unchanged except more console noise on failures. URL redaction reduces accidental credential leakage in logs.

Overview
Preview bridge and related failures are no longer swallowed with empty .catch() handlers. A shared reportPreviewActionFailure helper logs [preview] action failed to console.error with structured context (operation, threadKey, tabId, artifact/annotation ids where relevant) and passes through the original cause.

PreviewView and PreviewMoreMenu now route navigation, zoom, history, refresh, DevTools, cache/cookies, recordings, screenshots, clipboard, element picker, and open-external errors through that helper. URL-related context uses previewUrlFailureContext, backed by new getUrlDiagnostics in @t3tools/shared/urlDiagnostics, so logs keep hostname, protocol, and length only—not full URLs, credentials, or query tokens. openPreviewSession atom failures are reported when not interrupted; picker failures stay silent in the UI but are logged.

Shared also adds redactDpopRequestTarget (scheme/host/path only) with tests; it is not wired into callers in this PR.

Reviewed by Cursor Bugbot for commit 8fe6259. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Report preview action failures via console.error with sanitized context

  • Adds reportPreviewActionFailure in reportPreviewActionFailure.ts that logs a structured console.error with operation name and context, replacing silent error swallowing across preview components.
  • Adds previewUrlFailureContext to derive sanitized URL diagnostics (hostname, protocol, input length) without leaking raw URLs, credentials, or query params.
  • Wires failure reporting into PreviewView.tsx for URL submission phases, navigation, session open, zoom, refresh, recording, screenshots, and element picking flows.
  • Wires failure reporting into PreviewMoreMenu.tsx for hard reload, devtools, zoom, cookie/cache clearing operations.
  • Behavioral Change: previously silent failures in preview actions now emit console.error entries with structured metadata.

Macroscope summarized 8fe6259.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6279b65c-8ed0-4cf7-9c48-51e3362e7b1b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/web-preview-action-errors

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jun 20, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Open session failures not reported
    • Added an explicit check for result._tag === "Failure" after awaiting openPreviewSession, calling reportPreviewActionFailure with the squashed cause so open-session failures get structured [preview] diagnostics instead of silently resolving.

Create PR

Or push these changes by commenting:

@cursor push 2d48ae75fc
Preview (2d48ae75fc)
diff --git a/apps/web/src/components/preview/PreviewView.tsx b/apps/web/src/components/preview/PreviewView.tsx
--- a/apps/web/src/components/preview/PreviewView.tsx
+++ b/apps/web/src/components/preview/PreviewView.tsx
@@ -4,6 +4,7 @@
 import { type ScopedThreadRef } from "@t3tools/contracts";
 import { useCallback, useEffect, useRef, useState } from "react";
 
+import { squashAtomCommandFailure } from "@t3tools/client-runtime/state/runtime";
 import { useComposerDraftStore } from "~/composerDraftStore";
 import { previewAnnotationScreenshotFile } from "~/lib/previewAnnotation";
 import { ensureLocalApi } from "~/localApi";
@@ -109,11 +110,17 @@
           rememberPreviewUrl(threadRef, resolvedUrl);
         } else {
           operation = "open-session";
-          await openPreviewSession({
+          const result = await openPreviewSession({
             openPreview: open,
             threadRef,
             url: resolvedUrl,
           });
+          if (result._tag === "Failure") {
+            reportPreviewActionFailure(
+              { operation, threadKey, url: targetUrl },
+              squashAtomCommandFailure(result),
+            );
+          }
         }
       } catch (cause) {
         reportPreviewActionFailure(

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit df0a48f. Configure here.

Comment thread apps/web/src/components/preview/PreviewView.tsx
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 20, 2026
@macroscopeapp

macroscopeapp Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR replaces silent error swallowing with console.error logging for preview action failures. No runtime behavior changes to actual functionality - purely a debugging/observability improvement with tests and careful handling to avoid logging sensitive URL data.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review June 20, 2026 13:01

Dismissing prior approval to re-evaluate 3280e2c

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
@macroscopeapp macroscopeapp Bot dismissed their stale review June 20, 2026 16:08

Dismissing prior approval to re-evaluate 260cf6d

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jun 20, 2026
juliusmarminge and others added 5 commits June 20, 2026 09:15
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge juliusmarminge force-pushed the codex/web-preview-action-errors branch from 260cf6d to 8fe6259 Compare June 20, 2026 16:18
@macroscopeapp macroscopeapp Bot dismissed their stale review June 20, 2026 16:18

Dismissing prior approval to re-evaluate 8fe6259

@juliusmarminge juliusmarminge changed the base branch from main to codex/redact-dpop-request-target June 20, 2026 16:18
@juliusmarminge juliusmarminge force-pushed the codex/redact-dpop-request-target branch from b87e64a to 3167aeb Compare June 20, 2026 19:21
@juliusmarminge juliusmarminge merged commit 303b165 into codex/redact-dpop-request-target Jun 20, 2026
16 checks passed
@juliusmarminge juliusmarminge deleted the codex/web-preview-action-errors branch June 20, 2026 22:13
juliusmarminge added a commit that referenced this pull request Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge added a commit that referenced this pull request Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant