fix(codex): show project-local skills in composer - #7717
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 070c40c. Configure here.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR introduces new functionality to discover and display project-local skills from You can add or adjust custom eligibility rules. Learn more. |

Fixes #7710
Codex project skills installed under
.agents/skillswere available in the repository but missing from T3 Code's$picker because the composer only used skills reported by the provider.The server now discovers project-local
SKILL.mdfiles through a read-scoped RPC. The web, desktop, and mobile composers merge those results into Codex skill suggestions. Other providers are unchanged.Verification
$unslshows the project-localunslopskillvp test run packages/client-runtime/src/providerSkills.test.tsvp test run apps/server/src/workspace/WorkspaceEntries.test.ts apps/server/src/auth/RpcAuthorization.test.tsvp test run apps/server/src/server.test.ts -t "routes websocket rpc project file and skill reads"packages/contracts,packages/client-runtime,apps/server,apps/web, andapps/mobileNote
This PR was pushed on behalf of @Githubguy132010.
Model:
gpt-5.6-solReasoning effort:
highHarness: Codex Desktop with
codex-cli 0.147.0Note
Add project-local skills to composer for codex providers
projects.listSkillsRPC and serverWorkspaceEntries.listSkillsto scan.agents/skills/forSKILL.mdfrontmatter and return parsed skill entries with scopeprojectmergeProviderSkillsutil to union provider and project skills (project overrides by name) sorted by name; mobile and web composers fetch and merge these for codex providers when a cwd is setThreadComposerto receivethreadCwdinstead ofprojectWorkspaceRootso skill discovery uses the correct directoryWS_METHODS.projectsListSkillsrequiresAuthOrchestrationReadScope;WorkspaceEntries.listSkillssilently skips entries with unreadable or invalid frontmatterMacroscope summarized 6a78f76.
Note
Medium Risk
Adds a new workspace RPC that reads files under a client-supplied cwd. Scope is read-only and aligned with existing project file APIs, but it expands filesystem exposure for skill discovery.
Overview
Codex
$skill suggestions now include project-local skills from.agents/skills, not just skills reported by the provider.Adds a read-scoped
projects.listSkillsRPC that scansSKILL.mdfiles, parses YAML frontmatter, and returnsscope: "project"entries. Web and mobile composers fetch this for Codex when a cwd is set, merge with provider skills (project wins on name), and show a loading state while the query is pending.Mobile also passes
threadCwdinto the composer so discovery uses the thread workspace, not the project root.Reviewed by Cursor Bugbot for commit 6a78f76. Bugbot is set up for automated code reviews on this repo. Configure here.