fix(clients): keep opening responses visible after turns settle - #7723
fix(clients): keep opening responses visible after turns settle#7723t3dotgg wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a self-contained UI presentation fix that modifies how thread messages are folded/collapsed - keeping both first and terminal assistant messages visible instead of just the terminal one. Changes are limited to fold logic with corresponding test updates, no runtime or API impact beyond the intended visual behavior. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
bd54c0d to
3e65b62
Compare
Settled turns hid every assistant response except the last one. A short verification after a tool call could bury the main answer under the Worked for row.
Keep the first and terminal assistant messages visible on web and mobile. Tool work and any middle narration still fold, and the fold row now appears where the hidden work starts.
Closes #7518 and #7529.
Tests
vp test run apps/web/src/components/chat/MessagesTimeline.logic.test.ts apps/mobile/src/lib/threadActivity.test.tsvp run --filter @t3tools/web --filter @t3tools/mobile typecheckvp lint,vp fmt, andgit diff --checkBuilt with GPT-5.6 Codex in the Codex harness through T3 Code.
Note
Low Risk
Presentation-only change to chat fold logic on web and mobile, with matching tests. No auth, data, or backend behavior is involved.
Overview
Settled turns no longer hide the opening assistant reply behind the Worked for row. A short verification after tools could bury the main answer; the first and terminal assistant messages now stay visible on web and mobile.
Tool activity and any middle narration still collapse. The fold row is anchored at the first hidden entry so it sits between those two messages rather than above the opening reply.
Reviewed by Cursor Bugbot for commit 3e65b62. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Keep first and terminal assistant messages visible around settled turn folds
deriveThreadFeedTurnFolds(mobile) andderiveTurnFolds(web) to track the first assistant message per turn and exclude it, along with the terminal assistant message, fromhiddenEntryIds.createdAtnow come from the first hidden entry (firstHiddenEntry) instead of the group's first entry, with a guard ensuring it exists before creating a fold.firstHiddenEntryguard handles empty middle sets as expected.Macroscope summarized 3e65b62.