Skip header comments in json manifests #5332
Open
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many json files have comments prepended using the characters # or // comment characters. For example, the json files generated by vscode. A least one manifest parsed by platformio-core, library.json in the Unity, has comments. (See ThrowTheSwitch/Unity#722) This change skips the header comments in json files.
Author
|
I assume this change should also have a test in tests/package/test_manifiest.py Also, currently this change does not support a file with a comment, white space, and then a comment. Perhaps it will be more robust to add that coverage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many json files have comments prepended using
the characters # or // comment characters. For example, the json files generated by vscode. A least one manifest parsed by platformio-core, library.json in the Unity, has comments. (See ThrowTheSwitch/Unity#722)
This change skips the header comments in json files.