-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: Preserve submit button value in form submissions with custom events #5900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hi, bringing this up in case it got missed. The checks are still awaiting approval and I’m happy to make any required updates. |
|
Hey! Sorry about the wait. This has been a long-standing bug in our tracker and I'm glad you've proposed a fix. Thank you! 🙏 The tracker code has pretty extensive test coverage and this feels like something that should be tested as well. To move forward there's 2 options:
|
|
Hi! I’ve added the test you requested. It verifies that the submit button’s value is preserved when forms are submitted with custom events, and confirms that the expected payload includes the correct provider value. Everything now aligns with the expected behavior from the issue. Happy to update anything further if needed, and thank you for the clear feedback! |
|
@iraprabhu05 I've approved the workflows. The test is failing and there's a formatting issue |
ukutaht
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test needs to be fixed
Changes
Fixes incorrect event name parsing in
custom-events.jsfor issue #5050.Added proper handling so custom events trigger correctly with updated tracking logic.
Tests
Changelog
Documentation
Dark mode