Skip to content

keep footer consistent#6339

Merged
zoldar merged 16 commits into
masterfrom
metmarkosaric-patch-2
Jun 1, 2026
Merged

keep footer consistent#6339
zoldar merged 16 commits into
masterfrom
metmarkosaric-patch-2

Conversation

@metmarkosaric
Copy link
Copy Markdown
Contributor

Changes

Please describe the changes made in the pull request here.

Below you'll find a checklist. For each item on the list, check one option and delete the other.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
Comment thread lib/plausible_web/templates/layout/_footer.html.heex Outdated
@zoldar zoldar force-pushed the metmarkosaric-patch-2 branch from 69e506d to 4a8d428 Compare June 1, 2026 11:08
@zoldar
Copy link
Copy Markdown
Contributor

zoldar commented Jun 1, 2026

@metmarkosaric I'm assuming this was meant to make the footer consistent with the one in docusaurus, but when looking at current prod, I see that docs still have the existing footer layout and I don't see any pending docs PRs that would match 🤔 Do we still want this merged?

@metmarkosaric
Copy link
Copy Markdown
Contributor Author

@zoldar thanks for your help reviewing all these changes! this update was meant to make the in-app footer more consistent with the footer people see on the site when they're not logged-in (you can see it on a page like this https://plausible.io/#pricing). we made quiet a few changes to the logged-out footer over the last few months. but it's just some links being changed here, there shouldn't be any design changes

metmarkosaric and others added 16 commits June 1, 2026 13:41
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
Co-authored-by: Hricha Shandily <103104754+Hricha-Shandily@users.noreply.github.com>
@zoldar zoldar force-pushed the metmarkosaric-patch-2 branch from 4a8d428 to 6093a4b Compare June 1, 2026 11:41
@zoldar zoldar enabled auto-merge June 1, 2026 11:48
@zoldar zoldar added this pull request to the merge queue Jun 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@zoldar zoldar added this pull request to the merge queue Jun 1, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@zoldar zoldar added this pull request to the merge queue Jun 1, 2026
Merged via the queue into master with commit b4ddf10 Jun 1, 2026
37 of 39 checks passed
@zoldar zoldar deleted the metmarkosaric-patch-2 branch June 1, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants