Exploration UI refactor#6408
Merged
Merged
Conversation
aerosol
reviewed
May 27, 2026
| } else { | ||
| return number.toFixed(1).replace(/\.0$/, '') + '%' | ||
| } | ||
| return roundedNumberFormatter(number) + '%' |
zoldar
force-pushed
the
exploration-ui-refactor
branch
from
60cb8ff to
d162f9b
Compare
apata
approved these changes
Jun 1, 2026
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR attempts to do some gradual refactoring improvements to exploration UI logic.
So far, following changes were made:
stepMaxVisitorsis always a numeric value to avoid potential division by zero (TS did not catch that, strangely)Numberfor casting strings to numeric values (instead ofparseFloat)There's definitely potential for more but that's at least some small start.
@apata if you have any free cycles, I'd really appreciate your eyes on this. I'd be keen on going over the exploration UI code together if you'd like to, to provide any missing context or unclear intent.