Remove _fullInput and other dead transforms code#7834
Open
emilykl wants to merge 10 commits into
Open
Conversation
camdecoster
approved these changes
Jun 10, 2026
camdecoster
left a comment
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Two things:
- Could you add a draftlog? Since this removes the deprecated code, it would be good to note that.
- Could you do a sweep for comments that mention transforms or
_fullData?
Contributor
Author
Sure, I can add a draftlog, it could help with debugging later, so not a bad idea. But the removed code was already inaccessible so I don't expect any user-facing changes.
Good idea! 0 matches for |
|
|
||
| // disable 1D transforms (for now) | ||
| // Ensure _length is defined | ||
| traceOut._length = null; |
Collaborator
There was a problem hiding this comment.
all these traceOut._length = null statements refer to disabling transforms... I'm pretty sure they can all be removed after #7240, specifically these lines.
| // thing at once manually. | ||
| var aStr = 'dimensions[' + initialDimIndex + '].constraintrange'; | ||
| var preGUI = fullLayout._tracePreGUI[gd._fullData[fullIndices[i]]._fullInput.uid]; | ||
| var preGUI = fullLayout._tracePreGUI[gd._fullData[fullIndices[i]].uid]; |
Collaborator
There was a problem hiding this comment.
fullIndices and inputIndices in parcoords are redundant at this point.
Collaborator
|
LGTM! Just a couple more items I bet we could remove, as noted above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #7250
trace._fullInputfield existed solely for keeping track of the original input trace after applying defaults but before applying transformstransformsfrom the API #7240, Remove transforms from bundles #7254),trace._fullInputis the same astracetrace._fullInputto simplytrace, and adjusts logic accordinglytrace._indexToPointswhich was likewise only used for transformstrace._fullInputortransformsThis PR should have zero user-facing impact.