Skip to content

refactor: Generate union of data types#7868

Merged
camdecoster merged 2 commits into
v4.0from
cam/7867/generate-data-union-type
Jun 25, 2026
Merged

refactor: Generate union of data types#7868
camdecoster merged 2 commits into
v4.0from
cam/7867/generate-data-union-type

Conversation

@camdecoster

@camdecoster camdecoster commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Update generator script to create union of data types.

Closes #7867.

Changes

  • Update generator script
  • Update import statements
  • Update docs
  • Delete hand written type
  • Update generated types

Testing

  • Be on this branch
  • Run the typecheck: npm run typecheck
  • Note there are no errors
  • Update the schema: npm run schema
  • Note that there are no errors

@camdecoster camdecoster added the no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped. label Jun 25, 2026

@KoolADE85 KoolADE85 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here.
Curious if this is considered a "breaking" change in the sense that end users may need to update existing imports from core/data?

@camdecoster

Copy link
Copy Markdown
Contributor Author

It's not breaking because... it hasn't been released yet! But good call out.

@camdecoster camdecoster merged commit ed11c35 into v4.0 Jun 25, 2026
84 of 85 checks passed
@camdecoster camdecoster deleted the cam/7867/generate-data-union-type branch June 25, 2026 17:20
@camdecoster camdecoster added this to the v4.0.0 milestone Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-draftlog The associated PR doesn't require a draftlog and the CI check will be skipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants