Update plotly.js to v4.0.0-rc.0#5673
Open
emilykl wants to merge 12 commits into
Open
Conversation
emilykl
force-pushed
the
update-plotlyjs-v4.0.0-rc.0
branch
from
July 23, 2026 16:08
e9e1d18 to
d3c2587
Compare
camdecoster
reviewed
Jul 23, 2026
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
- Could we update the docs separately to keep things tidy?
- I think we can remove the Stream deprecation warning in _deprecations.py
- I still see a lot of references to
linkText/link_textandshowLink/show_link. Could those be removed? ColorValidatorwill need to be updated per the v4 changes
Contributor
There was a problem hiding this comment.
ColorValidator will need to be updated to remove the references and regex checks for hsv since that got removed. The regex patterns will also need to be updated to match the new color specifier support.
Contributor
Author
Yes, as long as you're OK with the docs build failing on this PR. I'll split the docs changes into a separate PR.
👍 will do, thanks |
emilykl
force-pushed
the
update-plotlyjs-v4.0.0-rc.0
branch
from
July 23, 2026 20:48
cb56252 to
3a76e7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
v4.0.0-rc.0mapboxin Plotly ExpressmapboxreferencesNote: The failing
plotly.js dev buildCI job can be ignored. That job runs the tests after pullingdist/plotly.jsfrom the plotly.jsmasterbranch, so naturally it will fail since the plotly.js v4.0 changes are not yet onmaster.The failing docs build can also be ignored; it will fail until the docs are updated to remove
mapboxcode, which will be in a separate PR.