chore(tests): add GLTFLoader integration test#3567
Closed
rkeshwani wants to merge 1 commit intopmndrs:fix/native-responsetypefrom
Closed
chore(tests): add GLTFLoader integration test#3567rkeshwani wants to merge 1 commit intopmndrs:fix/native-responsetypefrom
rkeshwani wants to merge 1 commit intopmndrs:fix/native-responsetypefrom
Conversation
This commit adds an integration test for `useLoader` with `GLTFLoader`. The test verifies that the loader can correctly parse a binary GLB file. To achieve this in a Node.js test environment, the following changes were made: - `node-fetch` is added as a dev dependency to provide `fetch`, `Request`, and `Response` objects. - These are polyfilled globally in the Jest setup file for all tests to use. - The test mocks the `fetch` call to return a minimal, valid GLB file as an `ArrayBuffer`. This approach was chosen after discovering that the native test environment does not support the features required for a full native integration test.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d6f25b6:
|
Member
|
Thanks for this. It helps. My time has been sparse lately, but I am looking into this issue. |
CodyJasonBennett
changed the title
Member
|
Migrated to https://github.com/pmndrs/native |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is made in attempt to remove the following blocker. pmndrs/native#9
There is an existing PR #3086 and this is to solve the blocker on that pr.
This commit adds an integration test for
useLoaderwithGLTFLoader.The test verifies that the loader can correctly parse a binary GLB file. To achieve this in a Node.js test environment, the following changes were made:
node-fetchis added as a dev dependency to providefetch,Request, andResponseobjects.fetchcall to return a minimal, valid GLB file as anArrayBuffer.This approach was chosen after discovering that the native test environment does not support the features required for a full native integration test.