feat: add object3DName and userData props for Object3D access #239
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UIKitObject3DProps interface to allow setting the underlying Object3D's name and userData properties. This is useful for debugging and writing automated tests. - object3DName: sets the Object3D.name property - userData: sets custom user data on the Object3D The name prop is prefixed as object3DName to avoid conflicts with components like Input that already have a name property for HTML form semantics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
object3DNameprop to set the underlying Three.js Object3D'snamepropertyuserDataprop to set custom user data on the Object3Dbuild()wrapperMotivation
These props are useful for debugging and writing automated tests, allowing developers to: