README: details about running locally and Netlify deploys#139
Open
cben wants to merge 2 commits intopomber:masterfrom
Open
README: details about running locally and Netlify deploys#139cben wants to merge 2 commits intopomber:masterfrom
cben wants to merge 2 commits intopomber:masterfrom
Conversation
cben
commented
Jul 12, 2019
| yarn install | ||
| yarn start | ||
|
|
||
| it'll open the starting page in browser, you'll want to append the path that comes after `https://github.com/` |
Author
There was a problem hiding this comment.
I didn't complete formulating this sentence perhaps.
But the reason this needs clarification in the first place, is that starting page always says "2. Replace github.com with github.githistory.xyz". Ideally it'd use current domain, e.g. "2. Replace github.com with localhost:3000" or "2. Replace github.com with deploy-preview-139--github-history.netlify.com".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
These details are pretty easy to discover, but might help contributors.
The instructions for Netlify on a fork are perhaps overkill, most people won't need that (is this clear from the text? Or is it unnecessarily scaring?). I just wanted to document
yarn buildcommand andbuilddirectory settings, but feel free to drop that.