chore: remove swap_vanity_url() and accommodate new API fields#493
chore: remove swap_vanity_url() and accommodate new API fields#493
Conversation
| "owner_guid" = NA_character_ | ||
| "owner_guid" = NA_character_, | ||
| "gid" = NA_character_ |
There was a problem hiding this comment.
Is this separate from removing the swap vanity url stuff? I'm fine to bundle it in one PR, but I want to make sure I'm following.
There was a problem hiding this comment.
yeah it was a change to fix integration tests in CI on the preview version of Connect. I can also pull it out into a separate PR too if you prefer; either way I need to figure out what is going on with the integration tests for 2022-2023 versions first.
There was a problem hiding this comment.
OK, no problem to leave it here, but maybe mention it in the PR description? Or these comments are enough record of what's up maybe?
| expect_gt(length(colnames(groups_list)), 1) | ||
|
|
||
| expect_ptype_equal(groups_list_local, connectapi_ptypes$groups) | ||
| expect_ptype_equal(groups_list_local, connectapi_ptypes$groups, exact = FALSE) |
There was a problem hiding this comment.
Same with this, this looks like it's something slightly different from the swap vanity urls thing?
| \code{\link{set_run_as}()}, | ||
| \code{\link{set_thumbnail}()}, | ||
| \code{\link{set_vanity_url}()}, | ||
| \code{\link{swap_vanity_url}()}, |
There was a problem hiding this comment.
Nothing you're doing (or should do) in this PR but OMG how we have to change so many .Rd files when we touch anything :(
Possibly but it's weird to me that integration tests on other versions of connect that use the same license file are passing |
Yeah, very strange indeed! And as of last week, at least, main was fine, too 🙃 |
karawoo
changed the title
2 participants
Intent
#491 removed
get_job()which was deprecated in 0.6.0. Since we are getting ready to do another connectapi release I think it makes sense to remove the other function that was deprecated in 0.6.0,swap_vanity_url().Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?