-
Notifications
You must be signed in to change notification settings - Fork 67
Implement pm.require #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pm.require #976
Conversation
package.json
Outdated
| "tsd-jsdoc": "^2.5.0", | ||
| "tv4": "1.3.0", | ||
| "uniscope": "2.0.1", | ||
| "uniscope": "postmanlabs/uniscope#feat/three-way-diff", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1e089e6 to
eba9f5a
Compare
| return cache[path].exports; | ||
| } | ||
|
|
||
| /* eslint-disable-next-line one-var */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codenirvana I don't see the use of this eslint rule. I want to use const because the value never changes, but I don't want to evaluate it if I can bail out early. What're your thoughts?
eba9f5a to
198a140
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #976 +/- ##
===========================================
- Coverage 60.71% 60.56% -0.15%
===========================================
Files 12 12
Lines 560 563 +3
Branches 136 136
===========================================
+ Hits 340 341 +1
- Misses 220 222 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
198a140 to
e7d4ed5
Compare
package.json
Outdated
| "dependencies": { | ||
| "lodash": "4.17.21", | ||
| "postman-collection": "4.3.0", | ||
| "postman-collection": "aditya-baradwaj/postman-collection#feature/APITEST-766-Add-Packages-to-collection-schema", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d90738f to
acb1ca5
Compare
277f79d to
552088e
Compare
Adds
pm.requireto thepmAPI.When
resolvedPackagesoption is passed to the sandbox inexecute, thepm.requireAPI can be used to import the packages from theresolvedPackagescache.modules.exportis exported from the package.test/unit/sandbox-libraries/pm-require.test.jsfor more cases.Note: Commits e7d4ed5 and 42e7dcd can be removed once
postman-collectionanduniscopeare bumped.