Ks/optimal models tests#227
Closed
kstrauch94 wants to merge 11 commits into
Closed
Conversation
Collaborator
kstrauch94
commented
Apr 9, 2026
kstrauch94
commented
- Add better way to test for optimal models
- Add support to test optimal models of the propagator (Fix Optimization unit tests for the propagator #69)
- Propagator now implements stage system to look for optimal models, no need to manually switch
kstrauch94
force-pushed
the
ks/optimal-models-tests
branch
2 times, most recently
from
b42a1c0 to
d3d6d9d
Compare
One has precision and it used by the compile engine the other is for all engines.
kstrauch94
force-pushed
the
ks/optimal-models-tests
branch
from
284608f to
8f15725
Compare
Member
|
@kstrauch94 Merge conflicts notwithstanding, is this ready to be merged or are you still on it? |
Member
|
I've merged the changes. I did in a different branch because the rebasing/merging was non-trivial. We can close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.