-
Notifications
You must be signed in to change notification settings - Fork 0
feat: advanced join semantics, transactional integrity, and expanded SLT suite #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4a6dc1c
feat(storage): implement rollback support in HeapTable and expand Und…
poyrazK 9ec25d0
feat(txn): implement DML undo logic and persistent execution state
poyrazK 1291e55
feat(parser): add RIGHT/FULL join support and fix pagination parsing
poyrazK 980eed3
feat(executor): implement FULL/RIGHT join semantics and fix LimitOper…
poyrazK af42245
test(logic): expand SLT coverage for Transactions, Indexes, and Joins
poyrazK ef9dd0c
docs: update features and roadmap for advanced joins and transactiona…
poyrazK 2a22adf
style: automated clang-format fixes
poyrazK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,7 @@ enum class TokenType : uint8_t { | |
| Join, | ||
| Left, | ||
| Right, | ||
| Full, | ||
| Inner, | ||
| Outer, | ||
| Order, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
Make
UPDATEundo logs impossible to record withoutold_rid.src/transaction/transaction_manager.cpponly restores the old tuple version forUndoLog::Type::UPDATEwhenold_ridis present. With this signature, a caller can forget the fourth argument and rollback will silently remove the new tuple while leaving the old one hidden. This API should enforce that invariant instead of relying on every call site to remember it.One way to enforce the invariant
void add_undo_log(UndoLog::Type type, const std::string& table_name, const storage::HeapTable::TupleId& rid, std::optional<storage::HeapTable::TupleId> old_rid = std::nullopt) { + if (type == UndoLog::Type::UPDATE && !old_rid.has_value()) { + throw std::invalid_argument("UPDATE undo log requires old_rid"); + } undo_logs_.push_back({type, table_name, rid, old_rid}); }🤖 Prompt for AI Agents