Tests: Fix flaky GPP tests and refactor code by osulzhenko · Pull Request #4309 · prebid/prebid-server-java

osulzhenko · 2025-12-04T12:25:31Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

github-actions · 2025-12-04T12:31:09Z

	Tests	Passed ✅	Skipped ⚠️	Failed
JUnit Test Report	9058 ran	9056 passed	2 skipped	0 failed

View JUnit Test Report

marki1an

Comments applicable to other cases.

marki1an · 2025-12-04T13:13:31Z

src/test/groovy/org/prebid/server/functional/model/config/DataActivity.groovy

+
+    static DataActivity fromGppDataActivity(GppDataActivity gppActivity) {
+        if (gppActivity == null) {
+            return INVALID;


Don't need semicolon here.

marki1an · 2025-12-04T13:14:40Z

src/test/groovy/org/prebid/server/functional/model/config/DataActivity.groovy

    NOTICE_NOT_PROVIDED(2),
    NO_CONSENT(1),
    CONSENT(2),
-    INVALID(-1),
+    INVALID(-1)


Please reorder your number without duplication.

marki1an · 2025-12-04T13:17:09Z

src/test/groovy/org/prebid/server/functional/model/config/DataActivity.groovy

+        switch (gppActivity) {
+            case GppDataActivity.NOT_APPLICABLE:
+                return NOT_APPLICABLE
+            case GppDataActivity.NO_CONSENT:
+                return NO_CONSENT
+            case GppDataActivity.CONSENT:
+                return CONSENT
+            default:
+                return INVALID
+        }
+    }


In general, looks weird. Please consider removing the current enum.

marki1an · 2025-12-04T13:22:10Z

src/test/groovy/org/prebid/server/functional/model/config/GppModuleConfig.groovy

+    enum ConfigCase {
+        CAMEL_CASE, KEBAB_CASE, SNAKE_CASE


I propose to move into the core model. In future, we can also reuse this functionality.

src/test/groovy/org/prebid/server/functional/model/config/GppModuleConfig.groovy

marki1an · 2025-12-04T15:18:24Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

-        accountGppConfig << [
-                new AccountGppConfig(code: IAB_US_GENERAL, enabled: false),
-                new AccountGppConfig(code: IAB_US_GENERAL, config: new GppModuleConfig(skipSids: [US_NAT_V1]), enabled: true)
-        ]
+        accountGppConfig << [new AccountGppConfig(code: IAB_US_GENERAL, enabled: false),
+                             new AccountGppConfig(code: IAB_US_GENERAL, config: new GppModuleConfig(skipSids: [US_NAT_V1]), enabled: true)]


marki1an · 2025-12-04T15:19:28Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

-        new UsNatV1Consent.Builder().setPersonalDataConsents(GppDataActivity.CONSENT).build() | [new EqualityValueRule(GPC, NOTICE_PROVIDED),
-                                                                                                 new EqualityValueRule(PERSONAL_DATA_CONSENTS, NOTICE_NOT_PROVIDED)]
+        gppConsent                                                            | valueRules
+        new UsNatV1Consent.Builder().setPersonalDataConsents(CONSENT).build() | [new EqualityValueRule(PERSONAL_DATA_CONSENTS, DataActivity.NOTICE_NOT_PROVIDED)]


DataActivity static import?

marki1an · 2025-12-04T15:21:18Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy

-        disallowGppLogic << [
-                SIMPLE_GPC_DISALLOW_LOGIC,
-                new UsNatV1Consent.Builder()
-                        .setMspaServiceProviderMode(MspaMode.YES)
-                        .setMspaOptOutOptionMode(MspaMode.NO)
-                        .build(),


Let's create a rule to format this?

We need to define one standard for all tests with the best practices

marki1an · 2025-12-04T15:24:38Z

src/test/groovy/org/prebid/server/functional/tests/privacy/PrivacyBaseSpec.groovy

+        def sensitiveData
+        def consentBuilder


Please use proper Obj instead of def

marki1an · 2025-12-04T15:31:12Z

src/test/groovy/org/prebid/server/functional/tests/privacy/PrivacyBaseSpec.groovy

+        def childSensitiveData
+        def consentBuilder


marki1an · 2025-12-05T13:25:12Z

.../groovy/org/prebid/server/functional/model/privacy/gpp/UsColoradoV1ChildSensitiveData.groovy

Please remove unused imports, same for others

src/test/groovy/org/prebid/server/functional/tests/privacy/PrivacyBaseSpec.groovy

Tests: Fix flaky GPP tests and refactor code

3052ca9

osulzhenko requested a review from marki1an December 4, 2025 12:25

osulzhenko self-assigned this Dec 4, 2025

osulzhenko added tests Functional or other tests do not port labels Dec 4, 2025

remove empty lines

11997ca

marki1an requested changes Dec 4, 2025

View reviewed changes

update after review

f208473

osulzhenko requested a review from marki1an December 5, 2025 12:02

marki1an requested changes Dec 5, 2025

View reviewed changes

osulzhenko added 2 commits December 5, 2025 16:04

update after review

e687601

update after review

1121074

marki1an previously approved these changes Dec 5, 2025

View reviewed changes

update after review

1019c2d

osulzhenko dismissed marki1an’s stale review via 1019c2d December 5, 2025 14:17

marki1an approved these changes Dec 5, 2025

View reviewed changes

osulzhenko assigned marki1an and unassigned osulzhenko Dec 8, 2025

CTMBNara approved these changes Dec 9, 2025

View reviewed changes

CTMBNara merged commit 5ebc21f into master Dec 9, 2025
9 checks passed

CTMBNara deleted the functional-tests/update-gpp-tests branch December 9, 2025 00:24

Conversation

osulzhenko commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marki1an left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

osulzhenko commented Dec 4, 2025 •

edited

Loading

github-actions bot commented Dec 4, 2025 •

edited

Loading