Skip to content

Mobkoi: Always set TagID with placementID#4644

Merged
bsardo merged 1 commit intoprebid:masterfrom
gabrielmougard:mobkoi-MAX-1892
Mar 3, 2026
Merged

Mobkoi: Always set TagID with placementID#4644
bsardo merged 1 commit intoprebid:masterfrom
gabrielmougard:mobkoi-MAX-1892

Conversation

@gabrielmougard
Copy link
Copy Markdown
Contributor

We have a discrepancy between our Prebid Server and our Tag/PrebidJS integration. It’s not replacing the bidrequest.Imp[0].TagID with our internal value when a TagID is already present.

We are able to deliver because the value is set in the bidrequest.Imp[0].Ext.placementID field, but this creates discrepancies between the connectors, and it’s not ideal.

We have a discrepancy between our Prebid Server and our Tag/PrebidJS integration. It’s not replacing the `bidrequest.Imp[0].TagID` with our internal value when a TagID is already present.

We are able to deliver because the value is set in the `bidrequest.Imp[0].Ext.placementID` field, but this creates discrepancies between the connectors, and it’s not ideal.
@github-actions
Copy link
Copy Markdown

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c20c98a

mobkoi

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:27:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:34:	MakeRequests	90.9%
github.com/prebid/prebid-server/v3/adapters/mobkoi/mobkoi.go:80:	MakeBids	100.0%
total:									(statements)	94.6%

@bsardo bsardo merged commit b9da50d into prebid:master Mar 3, 2026
3 checks passed
@bsardo bsardo changed the title Mobkoi: Always set the TagID with our placementID Mobkoi: Always set TagID with placementID Mar 3, 2026
t-sormonte pushed a commit to Viously/prebid-server-go that referenced this pull request Mar 20, 2026
anthonyrichir pushed a commit to proxistore/prebid-server that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants