Open
Conversation
stoivo
force-pushed
the
v2-css-parser-document
branch
from
71850c9 to
3a52163
Compare
grosser
approved these changes
Jun 13, 2024
Contributor
grosser
left a comment
grosser
left a comment
There was a problem hiding this comment.
seems easier to understand 👍
lmk if it's ready to merge
This Comes with another benefit too. It allow users to replace the logic for how reading url should work. If they don't want to allow http or follow redirects for 60 seconds.
stoivo
force-pushed
the
v2-css-parser-document
branch
from
3a52163 to
62b590c
Compare
Can find any use of it
Media queries can be anything so it don't make much sense to have it as symbol. The media "print" seam like could be nice as a media query but it can be combined with "max-width: 1px", to "pring and max-width: 1px)" which make less sense as a symbol.
Instances of CssParser::Parser had little to nothing to do with parsing the actual css. It's a wrapper to hold the ruleset and give some convince method on top of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to to try to clean up the Parser class. I have more to come, just want to open the MR if so I can get some feedback