-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: show date selection onClick #8359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: show date selection onClick
|
@Coderxrohan can you review this one and check if your other fixes already fixed this issue? |
|
I tested this behavior, https://stackblitz.com/edit/vitejs-vite-8xz26kct?file=src%2FApp.tsx What I observed:
From my testing, this behavior is not related to my recent changes and is not fixed by them. Sharing the StackBlitz repro here so we can confirm whether this is expected behavior or something that should be adjusted. |
|
Just to clarify the distinction between the previous fix and this issue: The fix I worked on earlier (#8302 / #8323) addressed an auto-refocus problem in single selection mode. The behavior discussed here is different. So:
There is no functional overlap between the two, and my previous changes neither caused nor fixed this behavior. |
|
@Coderxrohan i agree. |
8359.mp4Testting Locally on Localhost |
|
@melloware
|
|
It might be a react strict mode thing with double hook calls? |
Yes, I think that’s very likely 👍 The inconsistent behavior only appears in environments running React Strict Mode (StackBlitz / primereact.org), while localhost and the CodeSandbox PR branch behave normally. This points to double-invoked effects or focus/overlay timing differences under Strict Mode rather than an issue introduced by this PR. From my side, nothing further to add — the fix looks good and the remaining behavior can be evaluated separately if we decide to handle Strict Mode explicitly. |
Fixes #8352