A five second spot every ten minutes - #230
Merged
Merged
Conversation
Back from the ten seconds the interval was turned down to while the chain was being watched. That is done: the fill, the audio at streaming level, the entitlement check and the playback have all now been seen working together on a real live channel, so the reason for the short interval is gone. Ten minutes against a five second spot is about one second in a hundred and twenty, which is the difference between a station that carries advertising and one that is mostly advertising. ?adsEvery= still overrides it, and since the query no longer gets lost on a shared link it works on the pages where somebody would want it. The test pins the number again, because it is a decision now rather than a value turned down to watch something work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back from the ten seconds the interval was turned down to in #228 while the chain was being watched. That is done — on a real live channel, end to end:
?ads=0is honoured on a shared link since The link's ad settings survive the page that strips them #229Ten minutes against a five second spot is about one second in a hundred and twenty: the difference between a station that carries advertising and one that is mostly advertising.
?adsEvery=still overrides it, and since #229 the query survives the address-bar strip, so it works on the shared links where somebody would actually want it.The test pins the number again, because it is a decision now rather than a value turned down to watch something work.
896 pass, 0 fail; both typechecks clean.
🤖 Generated with Claude Code