Skip to content

fix(deps): upgrade modules flagged by govulncheck - #821

Merged
Mzack9999 merged 1 commit into
devfrom
dwisiswant0/fix/deps/upgrade-modules-flagged-by-govulncheck
Nov 9, 2026
Merged

Mzack9999 merged 1 commit into
devfrom
dwisiswant0/fix/deps/upgrade-modules-flagged-by-govulncheck

Conversation

@dwisiswant0

@dwisiswant0 dwisiswant0 commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

govulncheck reports 11 vulnerabilities in code that cloudlist calls,
spread over six modules. Upgrade golang.org/x/net from v0.58.0 to
v0.60.0 (GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612,
GO-2026-6617); google.golang.org/grpc from v1.73.0 to v1.83.1
(GO-2026-6061, GO-2026-6348); github.com/andybalholm/brotli from v1.2.0
to v1.2.7 (GO-2026-6888); github.com/klauspost/compress from v1.18.7 to
v1.20.2 (GO-2026-6865); and github.com/yuin/goldmark from v1.7.4 to
v1.7.17 (GO-2026-5320).

GO-2026-5506 in go.opentelemetry.io/otel is fixed in v1.41.0, but grpc
v1.83.1 requires v1.44.0, so otel, otel/metric, and otel/trace move
from v1.36.0 to v1.44.0.

The upgrades also raise four direct requirements: golang.org/x/oauth2
from v0.30.0 to v0.36.0, google.golang.org/api from v0.240.0 to
v0.264.0, google.golang.org/protobuf from v1.36.6 to v1.36.11, and
cloud.google.com/go/asset from v1.21.1 to v1.22.0. The go directive
stays at 1.26.10.

oauth2 v0.36.0 deprecates google.CredentialsFromJSON, which the GCP
provider uses to load both the source credentials file and the service
account key, so staticcheck now reports SA1019 on both calls. The typed
replacement accepts a single credential type, and switching to it would
mean deciding which credential files to stop accepting. Keep the
existing calls and suppress SA1019 on them.

Fixes: #820

Summary by CodeRabbit

  • Chores
    • Updated the Go version and supporting libraries. No user-facing behavior changes.

govulncheck reports 11 vulnerabilities in code that cloudlist calls,
spread over six modules. Upgrade golang.org/x/net from v0.58.0 to
v0.60.0 (GO-2026-6603, GO-2026-6610, GO-2026-6611, GO-2026-6612,
GO-2026-6617); google.golang.org/grpc from v1.73.0 to v1.83.1
(GO-2026-6061, GO-2026-6348); github.com/andybalholm/brotli from v1.2.0
to v1.2.7 (GO-2026-6888); github.com/klauspost/compress from v1.18.7 to
v1.20.2 (GO-2026-6865); and github.com/yuin/goldmark from v1.7.4 to
v1.7.17 (GO-2026-5320).

GO-2026-5506 in go.opentelemetry.io/otel is fixed in v1.41.0, but grpc
v1.83.1 requires v1.44.0, so otel, otel/metric, and otel/trace move
from v1.36.0 to v1.44.0.

The upgrades also raise four direct requirements: golang.org/x/oauth2
from v0.30.0 to v0.36.0, google.golang.org/api from v0.240.0 to
v0.264.0, google.golang.org/protobuf from v1.36.6 to v1.36.11, and
cloud.google.com/go/asset from v1.21.1 to v1.22.0. The go directive
stays at 1.26.10.

oauth2 v0.36.0 deprecates google.CredentialsFromJSON, which the GCP
provider uses to load both the source credentials file and the service
account key, so staticcheck now reports SA1019 on both calls. The typed
replacement accepts a single credential type, and switching to it would
mean deciding which credential files to stop accepting. Keep the
existing calls and suppress SA1019 on them.

Fixes: #820
Signed-off-by: Dwi Siswanto <git@dw1.io>
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Go directive changes from 1.24.0 to 1.26.10, and selected direct and indirect dependencies are upgraded. GCP credential parsing adds SA1019 suppressions; its branches and error handling are unchanged.

Changes

Go maintenance

Layer / File(s) Summary
Go directive and dependency updates
go.mod
The Go directive changes to 1.26.10. Selected direct and indirect dependency versions are updated, including OAuth, Google API, Google Cloud, OpenTelemetry, and golang.org/x modules.
GCP credential parsing suppressions
pkg/providers/gcp/auth.go
SA1019 suppressions are added to the explicit source-credentials file and configured service-account key parsing paths. Credential-loading branches and error handling remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: dogancanbakir, mzack9999

Merge Risk: Minimal · up to 350fd

No merge-blocking issue was identified. Run the standard build and vulnerability checks before merging.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #820 requires that govulncheck report no reachable vulnerabilities. Its table lists 11 advisories. The PR description states target versions for every affected module. The go.mod summary confirm… Provide the go.mod requirement lines at the reviewed head for google.golang.org/grpc (v1.83.1), github.com/andybalholm/brotli (v1.2.7), github.com/klauspost/compress (v1.20.2), and github.com/yuin/goldmark (v1.7.17), plus the golang.org/x/n…
Passed Passed checks: 4 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(deps): upgrade modules flagged by govulncheck" matches the main change. The PR upgrades dependencies in go.mod to address 11 reachable vulnerabilities that govulncheck reported (issue #…
Out of Scope Changes check Passed All changes in go.mod are dependency version updates. They are tied to the vulnerability fixes in #820 or to the transitive requirements those fixes impose. The OpenTelemetry move to v1.44.0 is requir…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check

Explanation

The title "fix(deps): upgrade modules flagged by govulncheck" matches the main change. The PR upgrades dependencies in go.mod to address 11 reachable vulnerabilities that govulncheck reported (issue #820). The title names the dependency upgrades and the vulnerability scanner that flagged them. It does not mention the Go directive bump or the staticcheck SA1019 suppressions in pkg/providers/gcp/auth.go, but those are secondary to the main change.

Full details: Out of Scope Changes check

Explanation

All changes in go.mod are dependency version updates. They are tied to the vulnerability fixes in #820 or to the transitive requirements those fixes impose. The OpenTelemetry move to v1.44.0 is required by grpc v1.83.1, as the PR description states. The raises to golang.org/x/oauth2, google.golang.org/api, google.golang.org/protobuf, and cloud.google.com/go/asset are direct requirements of the upgraded dependencies, as the PR description states. The go directive change is a toolchain setting. The summary reports 1.24.0 to 1.26.10, while the PR description says it stays at 1.26.10. The conflict does not make the change unrelated to the dependency upgrades. In pkg/providers/gcp/auth.go, the change adds two staticcheck SA1019 suppression comments on google.CredentialsFromJSON calls. The PR description links these comments to the oauth2 v0.36.0 deprecation. The summary states that there are no runtime behavior changes. No unrelated functional change appears in the summary.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Full details: Linked Issues check

Explanation

Issue #820 requires that govulncheck report no reachable vulnerabilities. Its table lists 11 advisories. The PR description states target versions for every affected module. The go.mod summary confirms raises to golang.org/x (covers golang.org/x/net), OpenTelemetry, golang.org/x/oauth2, and google.golang.org/api. The go.mod summary does not confirm the raises for google.golang.org/grpc (GO-2026-6061, GO-2026-6348), github.com/andybalholm/brotli (GO-2026-6888), github.com/klauspost/compress (GO-2026-6865), or github.com/yuin/goldmark (GO-2026-5320). It also states that other listed dependencies remain unchanged, which conflicts with the description for grpc and the other unconfirmed modules. The go.sum file is excluded by the ignored_files rule '!**/*.sum', so it cannot confirm the module hashes. Without the go.mod requirement lines, the vulnerability fixes cannot be confirmed as present.

Resolution

Provide the go.mod requirement lines at the reviewed head for google.golang.org/grpc (v1.83.1), github.com/andybalholm/brotli (v1.2.7), github.com/klauspost/compress (v1.20.2), and github.com/yuin/goldmark (v1.7.17), plus the golang.org/x/net (v0.60.0) line. Include the go.mod diff hunks for these modules, or a corrected summary that lists them. Then reassess the linked issue requirements.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the modules in a row,
New versions hop into the file below.
Two credential paths wear warnings out of sight,
The GCP branches keep their course just right.
The bunny closes up its book at night.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 2c376e23-d263-4364-bc14-c56b31006be8
Commits

Reviewing files that changed from the base of the PR and between 701a227 and 350fdbd.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 2

  • go.mod
  • pkg/providers/gcp/auth.go

Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

@dwisiswant0
dwisiswant0 requested a review from Mzack9999 November 9, 2026 06:23
@Mzack9999
Mzack9999 merged commit 87ad6ff into dev Nov 9, 2026
8 checks passed
@Mzack9999
Mzack9999 deleted the dwisiswant0/fix/deps/upgrade-modules-flagged-by-govulncheck branch November 9, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[issue] govulncheck reports 11 reachable vulnerabilities in dependencies

2 participants