Tests: device_manager: create test suite for module - #6
Merged
Conversation
used for things like testing signals, gui elements, etc
The registry keys arent even names anymore so the test I was writing was failing.
Create tests for the device manager and the device/sensor/output classes. Most functionalities of the classes I can think of are covered. I've also tweaked some small things in the classes themselves that I found as I wrote the tests.
wjeffreys96
force-pushed
the
tests/device_manager/add_device_class_tests
branch
from
August 15, 2026 21:18
7db5646 to
87826d5
Compare
We don't need to run this on every sensor, that's redundant and pointless. just building one test sensor and testing that one is enough and probably more helpful. Use loopback mode test canbus for this.
wjeffreys96
force-pushed
the
tests/device_manager/add_device_class_tests
branch
3 times, most recently
from
August 15, 2026 21:26
795f862 to
29fdfbd
Compare
We don't need to test unsubscription in this test since we know from the previous tests that part is good
wjeffreys96
force-pushed
the
tests/device_manager/add_device_class_tests
branch
from
August 15, 2026 21:27
29fdfbd to
e48c4e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would add a suite of tests for the device_manager.py module. It also installs pytest_qt to the app which adds tooling to test things like signals and qt gui elements. There are also some minor tweaks to the module itself to aid and testing and also just small things I found while testing that I don't think deserve their own PR.