Bugfix/issue 7371#7447
Closed
calvinturbo wants to merge 9 commits intopubkey:masterfrom
Closed
Conversation
Changed Firestore replication, reads events from onSnapshot
Contributor
Author
|
Built RxDB with this pull request in my application, seems to resolve issue with needing to call reSync() for updates & also fixes no-updates for documents moving outside of replication scope |
Owner
|
Hi @calvinturbo |
reSync() is needed, because Firestore does not provide information about what data is changed, only that the document has changed or removed
Doc in test was only updating data in Firestore DB but not modifying serverTimestamp causing a failed test when using reSync()
Contributor
Author
|
Test "two collections" fails for some reason. It returns 5 documents instead of the 10 documents added. Tried all kinds of things but didn't get it working. Even when putting this in the test itself: it still only returns 5 documents via the Firestore onSnapshot after adding the 10 documents via RxDB. |
Owner
|
@calvinturbo any update on this? |
Owner
|
Closed because no answer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
Check #7371
Todos