Skip to content

Allow setting retain_repo_versions to null#1412

Merged
mdellweg merged 1 commit into
pulp:mainfrom
alexjfisher:fix_retain_repo_versions
Jun 8, 2026
Merged

Allow setting retain_repo_versions to null#1412
mdellweg merged 1 commit into
pulp:mainfrom
alexjfisher:fix_retain_repo_versions

Conversation

@alexjfisher

Copy link
Copy Markdown
Contributor

Setting is already NULLABLE in
pulp-glue/src/pulp_glue/common/context.py line 1586

NULLABLES = {"description", "remote", "retain_repo_versions"}

but cli didn't allow an empty string to be used.

@mdellweg

mdellweg commented Jun 5, 2026

Copy link
Copy Markdown
Member

Please add a changelog entry to this bugfix.

Setting is already `NULLABLE` in
`pulp-glue/src/pulp_glue/common/context.py` line 1586

```
NULLABLES = {"description", "remote", "retain_repo_versions"}
```

but cli didn't allow an empty string to be used.
@alexjfisher alexjfisher force-pushed the fix_retain_repo_versions branch from 971d57a to db0650c Compare June 5, 2026 10:28
@alexjfisher

Copy link
Copy Markdown
Contributor Author

Please add a changelog entry to this bugfix.

Done! (At least I think I've done it right! :) )

@mdellweg mdellweg merged commit f918700 into pulp:main Jun 8, 2026
17 checks passed
@alexjfisher alexjfisher deleted the fix_retain_repo_versions branch June 8, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants