Conversation
sabre1041
force-pushed
the
ostree
branch
4 times, most recently
from
1790d0a to
5c8cc16
Compare
|
Great addition. I tend to want to ask for tests... |
|
@mdellweg I can look to add in tests, but it will take a little bit of time. So two options.
Let me know which option that you would like to take |
|
I prefer option 2. This project (sadly) is very low traffic atm, and without some test coverage we can consider the addition broken from the time we merge it. Also i am in no rush here. Let me know if any of the testing process described in the readme is unclear. |
|
@mdellweg sounds good. I'll start tackling it soon and report back when its ready for a review |
| #!/usr/bin/python | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| # copyright (c) 2019, Matthias Dellweg |
There was a problem hiding this comment.
I don't think, you should put my copyright there...
Also can you add yourself to the authors in galayx.yml?
| content_guard: | ||
| description: | ||
| - Name of the content guard for the served content | ||
| - "Warning: This feature is not yet supported." |
|
|
||
| repository_version = self.entity["latest_version_href"] | ||
|
|
||
| # In check_mode, assume nothing changed |
There was a problem hiding this comment.
Is there a way to make this really idempotent? Maybe by checking if commits are part of the latest version? (Not so much of an ostree expert here.)
Signed-off-by: Andrew Block <andy.block@gmail.com>
2 participants
Support for ostree