(BOLT-109) Fix Windows long path support by replacing Dir[] with Find.find

[gavindidrichsen]

Summary

Fixes Windows long path issue where module extraction fails with Errno::ENAMETOOLONG when paths exceed 260 characters. The root cause: Ruby's Dir[] glob does not respect the Windows LongPathsEnabled registry setting.

For more information see BOLT-109

PLEASE can you do both a 5.0.5 and a 6.0.1 release fix?

Problem

When extracting modules with deep directory structures, Dir[] in root_dir method fails on Windows even with long paths enabled:

pry> Dir["#{@tmpdir}/**/metadata.json"].sort_by(&:length)[0]
Errno::ENAMETOOLONG: Filename too long - C:/Users/.../DSC_IEEnhancedSecurityConfiguration/en-US
# Path length: 263 characters (exceeds 260-char MAX_PATH limit)

This occurs despite LongPathsEnabled registry key being set to 1.

Solution

Replace Dir[] with Find.find, which properly respects Windows long path settings:

# Before
metadata_file = Dir["#{@tmpdir}/**/metadata.json"].sort_by(&:length)[0]

# After  
Find.find(@tmpdir) do |path|
  if File.basename(path) == 'metadata.json'
    # Find shortest path, same as original behavior
  end
end

Verification

Environment: Windows Server 2022, Ruby 3.2.5

Before (FAILS):

> bundle exec r10k puppetfile install
ERROR -> Module computermanagementdsc failed to synchronize due to Filename too long

After (SUCCESS):

> bundle exec r10k puppetfile install
# Success - 263-character paths created without error

Test Results

• 202/203 tests pass
• 1 pre-existing failure (also fails on main branch - unrelated to this PR)

Impact

• Fixes module installation failures on Windows with deep directory structures
• Affects Bolt 4.0.0+ users (regressed from Bolt 3.30.0 behavior)
• No functional changes on Linux/macOS
• Maintains backward compatibility

[bastelfreak]

Hey. I assume you are going to release this soonish. Would it be possible that you take a look at https://github.com/puppetlabs/forge-ruby/pulls/bastelfreak before doing a release?