Repository navigation
Discard partial compiler output when recovering package set upgrades - #809
Merged
Merged
Conversation
thomashoneyman
force-pushed
the
fix/package-set-interrupted-recovery
branch
2 times, most recently
from
October 18, 2026 00:04
a457c8b to
6a261de
Compare
f-f
force-pushed
the
fix/package-set-interrupted-recovery
branch
2 times, most recently
from
October 18, 2026 15:07
9b6b8ad to
892a860
Compare
Clear partial compiler output when an upgrade leaves a backup behind, and remove backups after completed rollbacks to preserve incremental compilation.
f-f
force-pushed
the
fix/package-set-interrupted-recovery
branch
from
October 18, 2026 15:30
892a860 to
b565594
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a package set upgrade gets interrupted, then it can leave the disk in a bad state which blocks further updates because the baseline package set no longer compiles, as described in #808.
Because a leftover
output-backupindicates that an upgrade didn't finish, I think we should fix this by clearing the compiler output before deleting that backup, and then rely on the existing package synchronization and compiling the baseline package set to rebuild it.I tested this locally after setting up the same case that caused the server to fail, and reproduced the failure, and then used this fix to go back to a clean state.
This fixes the recovery path in the case a job got interrupted, but it doesn’t do anything about the OOM (still not exactly sure why that happened).