add attributes caching to OCSP request#14445
Closed
abbra wants to merge 4 commits into
Closed
Conversation
Store the Python bytes object in a PyOnceLock so that repeated accesses return the same object without re-traversing the ASN.1 structure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Store the Python bytes object in a PyOnceLock so that repeated accesses return the same object without re-traversing the ASN.1 structure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Store the computed hash-algorithm object in a PyOnceLock so that repeated accesses avoid re-traversing the ASN.1 structure and re-constructing the Python hash object. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
Store the Python integer in a PyOnceLock so that repeated accesses avoid re-parsing the ASN.1 integer bytes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
alex
reviewed
Mar 8, 2026
alex
left a comment
alex
left a comment
Member
There was a problem hiding this comment.
hmm, caching things that are just type conversions/
| impl OCSPRequest { | ||
| #[getter] | ||
| fn issuer_name_hash(&self) -> &[u8] { | ||
| self.cert_id().issuer_name_hash |
Member
There was a problem hiding this comment.
I wonder if we should be returning some sort of buffer here that points into self (while ensuring self is alive, of course). Feels excessive to need to cache something that's just constructing a bytes object...
WDYT @reaperhulk
Member
|
I think this optimization isn't worth it at this time, but thank you for the other contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #14441