Remove unused CFFI bindings without specific consumer#14798
Merged
Conversation
alex
force-pushed
the
remove-unused-cffi-bindings
branch
from
f82d82f to
5006e58
Compare
alex
force-pushed
the
remove-unused-cffi-bindings
branch
2 times, most recently
from
833387f to
da53512
Compare
Drops bindings whose git history shows no specific user/consumer request — they were added in bulk during the cffi 1.0 conversion or as generic library setup, and are no longer referenced by cryptography itself. Bindings that were explicitly requested by external consumers (pyOpenSSL, mitmproxy, Tribler, etc.) are retained. Also removes the now-unused USE_CONST_X509 env var plumbing in build.rs, since the X509V3_CTX struct that depended on it is gone. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mitmproxy's tlsconfig addon calls X509_VERIFY_PARAM_set1_host, X509_VERIFY_PARAM_set_hostflags, and X509_VERIFY_PARAM_set1_ip via SSL._lib, so these have an external consumer and must stay. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
alex
force-pushed
the
remove-unused-cffi-bindings
branch
from
da53512 to
618775a
Compare
Member
Author
|
@mhils there's a few cffi things that mitmproxy is poking around for -- can we add proper pyopenssl APIs for those so mitmproxy isn't reliant on implementation details that will break |
reaperhulk
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops bindings whose git history shows no specific user/consumer request — they were added in bulk during the cffi 1.0 conversion or as generic library setup, and are no longer referenced by cryptography itself. Bindings that were explicitly requested by external consumers (pyOpenSSL, mitmproxy, Tribler, etc.) are retained.
Also removes the now-unused USE_CONST_X509 env var plumbing in build.rs, since the X509V3_CTX struct that depended on it is gone.