Don't treat core flags as unfilled positional values - #1085
Open
gyanu2507 wants to merge 1 commit into
Open
Conversation
--help already jumped to the initial context when it appeared after a task name. Other core flags like --dry did not, so a task still waiting on a positional would swallow them. Fixes pyinvoke#1084.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--helpafter a task name already jumped back to the core parser context.--dryand the rest did not, so a task still waiting on a positional would just swallow the flag.inv punch --dry alicenow sets dry-run and still fills the positional withalice.Fixes #1084.