[WIP] Make django_settings_is_configured return the first value always#708
Draft
blueyed wants to merge 5 commits intopytest-dev:mainfrom
Draft
[WIP] Make django_settings_is_configured return the first value always#708blueyed wants to merge 5 commits intopytest-dev:mainfrom
blueyed wants to merge 5 commits intopytest-dev:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 98.03% 98.03% +<.01%
==========================================
Files 32 32
Lines 1831 1836 +5
Branches 142 142
==========================================
+ Hits 1795 1800 +5
Misses 23 23
Partials 13 13
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=========================================
- Coverage 98.1% 98.01% -0.1%
=========================================
Files 32 32
Lines 1902 1861 -41
Branches 149 149
=========================================
- Hits 1866 1824 -42
Misses 23 23
- Partials 13 14 +1
Continue to review full report at Codecov.
|
0e879ae to
3361768
Compare
I have been seeing an issue, where it would return False initially, but
later True; causing an `AttributeError` with the `mailoutbox` fixture,
because `mail.outbox` was not set on the module.
This can happen with imported code that changes the environment, e.g.
via "wsgi/asgi.py":
> os.environ.setdefault("DJANGO_SETTINGS_MODULE", "foo.settings")
3361768 to
74e310a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been seeing an issue, where it would return False initially, but
later True; causing an
AttributeErrorwith themailoutboxfixture,because
mail.outboxwas not set on the module.This can happen with imported code that changes the environment, e.g.
via "wsgi/asgi.py":
TODO: