Fix dict order assertion output #14054
Closed
+56
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Refactor assertions for getmodpath method to improve clarity.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Author
|
After investigating further, this change impacts several existing assertion-diff contracts. I’m closing this PR and will look for a more suitable issue. Thanks for the review tools! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pytest’s assertion summary output currently reorders dictionary keys alphabetically, losing insertion order guaranteed by Python dictionaries.
This PR preserves insertion order in assertion output while keeping existing formatting behavior unchanged.
Problem
Assertion failures involving dictionaries use
reprlib.Repr, which sorts dictionary keys internally, leading to confusing output.Solution
Override dictionary representation in
SafeReprto usedict.__repr__, preserving insertion order.Tests
Added a regression test to ensure dictionary insertion order is preserved in assertion failure output.
Fixes #13503